adlibs icon indicating copy to clipboard operation
adlibs copied to clipboard

Update getExecutingScript to fix issue where "cnvr" labels are hardcoded into code

Open jeffreytgilbert opened this issue 7 years ago • 4 comments

https://github.com/conversant/ad-libs.js/blob/master/lib/dom/getExecutingScript.js

getExecutingScript has default flags set to options specific to an implementation in an external script, which is bad practice and could result in odd errors in other scripts using this functionality. Please remove this default label data and if that functionality is required, move those behaviors to params. It should not be required behavior. This is used in multiple places already and only one i know of requires this behavior.

jeffreytgilbert avatar Jul 05 '17 16:07 jeffreytgilbert

@jeffreytgilbert @msahagu2

This is a breaking change. We'll be moving to 3.0.0 with this update.

j-brown avatar Jul 05 '17 19:07 j-brown

WFM.

jeffreytgilbert avatar Jul 06 '17 19:07 jeffreytgilbert

@j-brown does that mean the external scripts using this functionality need to be updated as well? If so, can we open some JIRAs for those requests?

jeffreytgilbert avatar Jul 06 '17 19:07 jeffreytgilbert

@jeffreytgilbert Correct. We'll see breaking changes across the board.

j-brown avatar Jul 06 '17 19:07 j-brown