javascript-examples icon indicating copy to clipboard operation
javascript-examples copied to clipboard

Published 20 hours ago • verified publisher icon convergencelabs

Sidebar toggle issues

Open mmacfadden opened this issue 5 years ago • 2 comments

The side bar toggle will scroll off the screen. And when it does it goes OVER the title bar:

sidebar-toggle

We should have the side bar toggle be fixed in the middel (vertically) of the screen.

mmacfadden avatar Jan 10 '20 16:01 mmacfadden

Just pushed a fix for the z-index issue.

Also, notice in the screenshot how the header for the chat example looks different than for any other example. That was fixed in e5eda3cde1e48751c7fc136f883dca016f1cb624.

If we want the sidebar toggle to be position: fixed, we should make the whole sidebar fixed as well.

alalonde avatar Jan 10 '20 17:01 alalonde

@alalonde yes.. I had not pulled the latest yet.

What would making the whole sidebar fixed mean? Would have have to have is scroll inside its container? If so, I am not sure that would be intuitive to users The main problem is that you can easily scroll the toggle off the screen and not be able to find it. It seems natural to just have it centered.

mmacfadden avatar Jan 10 '20 17:01 mmacfadden