convergence-project icon indicating copy to clipboard operation
convergence-project copied to clipboard

No way to set old values when element has been removed from the model.

Open mmacfadden opened this issue 3 years ago • 1 comments

Versions

  • Convergence Version: 1.0.0-rc.12

Describe the Bug The code here:

https://github.com/convergencelabs/convergence-server/blob/8ded7fa5adaac3690520c98f53b0843072adab7d/src/main/scala/com/convergencelabs/convergence/server/backend/services/domain/model/RealtimeModel.scala#L239

Will insert None values or bogus values into the applied operations if the operation is noop'ed and the real time element is not in the model anymore.

Expected Behavior We have discussed potentially keeping deleted elements around in a recycle bin while conflicting operations could still come in.

mmacfadden avatar Feb 04 '22 18:02 mmacfadden

Another option is to update the schema to allow for null values in this condition. Right now we have the combination of not being able to compute the old value, but the database needing it.

mmacfadden avatar Feb 04 '22 18:02 mmacfadden