conventionalcommits.org icon indicating copy to clipboard operation
conventionalcommits.org copied to clipboard

docs(summary): rm `:` colon in type values

Open Roytangrb opened this issue 4 years ago • 3 comments

  • change wordings in next/index.md and v1.0.0/*.md
  • remove use of : colon in type values of summary. According to the spec, colon itself should not be a part of commit type

Roytangrb avatar Jan 02 '21 18:01 Roytangrb

@Roytangrb There are some conflicts, but I do really agree with your changes; so if you can fix those I am gonna merge this.

@bcoe any opinion?

damianopetrungaro avatar Mar 17 '21 15:03 damianopetrungaro

@damianopetrungaro thanks for the feedback. Conflict is resolved, and the changes are applied to the new translation file v1.0.0/index.zh-hans.md in the updated PR.

Roytangrb avatar Mar 17 '21 16:03 Roytangrb

Lovely, let's wait for some feedback on this from @bcoe to make sure we are on the same page ;) But since it is not part of the specs should be good to go 💪

damianopetrungaro avatar Mar 18 '21 11:03 damianopetrungaro