conventionalcommits.org icon indicating copy to clipboard operation
conventionalcommits.org copied to clipboard

Chore commit type

Open aleksator opened this issue 3 years ago • 8 comments

What do you think of not recommending a chore commit type as it was removed from Angular Convention in 2017?

As an alternative, defining a specific meaning for this (and others) commit type would be IMO a great addition to the spec.

aleksator avatar Oct 10 '20 14:10 aleksator

I fully agree. The meaning of the tag should be specified or at least a subset of the specification.

ciscoski avatar Nov 04 '20 11:11 ciscoski

FWIW, I've defined it as "a repetitive mechanical task such as updating requirements or translations."

nedbat avatar Feb 25 '21 15:02 nedbat

Is the chore replaced by ci and build? I saw some articles or comments that said this. But from this commit angular delete the chore type as it was overused, but not prepare to replace it with ci and build.

tianzhich avatar Sep 16 '21 07:09 tianzhich

I feel like chore is kinda too generic. I've replaced it with ci, build, vcs and enhance.

@tianzhich What's your usage?

daiyam avatar Sep 16 '21 07:09 daiyam

I feel like chore is kinda too generic. I've replaced it with ci, build, vcs and enhance.

@tianzhich What's your usage?

Yes - It's too generic so different teams use it in different ways. There are two teams in my company department, one of them use it like ci or build, another use it just like this words meaning some bothering little changes. IMO the conventional-commits team could remove it like Angular team or replaced it with some more specific words like what you did.

tianzhich avatar Sep 16 '21 08:09 tianzhich

We had the same discussion in our team (https://github.com/FlowingCode/DevelopmentConventions/issues/11). Since we are already using other types from the Angular convention (build:, ci:, etc) in addition to feat: and fix:, we settled on defining chore: as

Changes, not covered by other types

In practice, that means that chore: is used for changes to .gitignore, license headers, and static resources such as images.

javier-godoy avatar Sep 16 '21 13:09 javier-godoy

I see this issue having some 🔔 , what do you think @bcoe ?

Should we drop the support?

Maybe waiting for some more community to ask for this change?

damianopetrungaro avatar Sep 28 '21 16:09 damianopetrungaro

@damianopetrungaro Is there anything to be dropped? In strict sense, conventional-commits just specify that "types other than fix: and feat: are allowed". The mention of chore: is just by means of example.

Then, it's not an issue with Conventional Commits, but with the actual definition of "types other than fix: and feat:" as used by a specific community of practice. The definition adopted by the old Angular Convention ("other changes that don't modify src or test files") was too wide, but other definitions don't pose this problem: for instance, AngularJS defines it as "changes to the build process or auxiliary tools and libraries such as documentation generation" which is mostly equivalent to the build: and ci: types used by other teams.

javier-godoy avatar Sep 28 '21 17:09 javier-godoy