standard-version icon indicating copy to clipboard operation
standard-version copied to clipboard

Bump files are skipped using absolute path file

Open vallsv opened this issue 2 years ago • 2 comments

Hi,

standard-version was never bumping package.json on one of my project.

After some checks it looks like the file is filtered based on the absolute path of the file. As result dotgitignore can incorrectly answer that a file is ignored by .gitignore based on parent directory not part of the project.

How to reproduce

  • create a js project in /home/user/myproject/ with package.json
  • create a .gitignore containing home
  • try to release a new version
  • package.json is not updated because the abs path /home/user/myproject/package.json contains home

Current behavior

My package.json is not bumped.

Expected behavior

My package.json have to be bumped.

Environment

Possible Solution

Use relative path instead of absolute path for configFiles

vallsv avatar May 07 '22 11:05 vallsv

I also don't really understand why files are filtered based on .gitignore. For example why would you not bump package-lock.json even if it is part of the .gitignore? But that's another question anyway.

vallsv avatar May 07 '22 11:05 vallsv

Just stumbled onto the same bug, thanks for reporting @vallsv

(same behaviour on 9.5.0)

acidicX avatar May 19 '22 12:05 acidicX