standard-version
standard-version copied to clipboard
Bump files are skipped using absolute path file
Hi,
standard-version
was never bumping package.json
on one of my project.
After some checks it looks like the file is filtered based on the absolute path of the file.
As result dotgitignore
can incorrectly answer that a file is ignored by .gitignore
based on parent directory not part of the project.
How to reproduce
- create a js project in
/home/user/myproject/
withpackage.json
- create a
.gitignore
containinghome
- try to release a new version
-
package.json
is not updated because the abs path/home/user/myproject/package.json
containshome
Current behavior
My package.json
is not bumped.
Expected behavior
My package.json
have to be bumped.
Environment
-
[email protected]
-
[email protected]
- Node/npm version: 7.21.0
- OS: Debian 10
Possible Solution
Use relative path instead of absolute path for configFiles
I also don't really understand why files are filtered based on .gitignore
.
For example why would you not bump package-lock.json
even if it is part of the .gitignore
?
But that's another question anyway.
Just stumbled onto the same bug, thanks for reporting @vallsv
(same behaviour on 9.5.0)