releaser-tools icon indicating copy to clipboard operation
releaser-tools copied to clipboard

No semver tags found

Open shine1594 opened this issue 2 years ago • 1 comments

I'm using tagPrefix and I'm getting the following error: "Error: No semver tags found"

conventionalGithubReleaser(
  {
    type: "oauth",
    url: 'https://api.github.com',
    token: process.env.GITHUB_TOKEN,
  },
  {
    preset: "angular",
    tagPrefix: `${app}@`,
  },
  null,
  { from, to },
  (err, responses) => {
    if(err) console.log(err);
    else console.log(responses);
  }
);

It seems that the tagPrefix option is not applied to 'git-semver-tags'. https://github.com/conventional-changelog/releaser-tools/blob/3fc007be5ed0865a85bcb5c8842647d6efa81688/packages/conventional-github-releaser/src/index.js#L50

I'm not sure exactly what side effects it will have, but shouldn't it be modified like this?


Q.nfcall(
  gitSemverTags,
  { tagPrefix: changelogOpts.tagPrefix || '' },
  function (err, tags) {
    if (err) userCb(err)
    else resolve(tags)
  }
)

shine1594 avatar Jul 27 '21 11:07 shine1594

I'm having the same issue here. It will be awesome to support tagPrefix

beatriz1304 avatar Nov 12 '21 22:11 beatriz1304