commitlint icon indicating copy to clipboard operation
commitlint copied to clipboard

feat(container): switch to Alpine container

Open skycaptain opened this issue 1 year ago • 3 comments

Description

This reduces the container image size from about 950MB to 200MB.

Closes #4183.

Motivation and Context

See #4183

How Has This Been Tested?

$ docker buildx build -f Dockerfile.ci .

Types of changes

Although I've labeled this as a non-breaking change, it could potentially disrupt containers derived from this image. Please consider reclassifying it as a breaking change if necessary.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

skycaptain avatar Oct 18 '24 20:10 skycaptain

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Oct 18 '24 20:10 codesandbox-ci[bot]

/cc @kaiehrhardt @knocte would you mind having a look at this?

escapedcat avatar Oct 19 '24 10:10 escapedcat

I have no idea about how this Dockerfile.ci is used

knocte avatar Oct 19 '24 21:10 knocte

@escapedcat lgtm

kaiehrhardt avatar Oct 23 '24 22:10 kaiehrhardt

Is there a list of system dependencies for commitlint? I just realized yesterday that I forgot to add git, and I'm wondering whether there are more dependencies. Previously, many "basic" tools were available from the large base image, but they would now be missing if not explicitly installed. Are there other things I should test?

skycaptain avatar Oct 24 '24 05:10 skycaptain

Is there a list of system dependencies for commitlint?

Haven't seen one. I'm also not exactly sure. Maybe we try this, give it a try and adjust if needed?

escapedcat avatar Oct 24 '24 08:10 escapedcat

Jumping back on this PR. Is there anything still missing here, or shall we merge as @escapedcat suggested?

skycaptain avatar Nov 06 '24 13:11 skycaptain

@skycaptain hey, yes, sorry! Let me merge it these days and we'll see what happens ;)

escapedcat avatar Nov 06 '24 16:11 escapedcat

Done 🤞

escapedcat avatar Nov 08 '24 09:11 escapedcat

Looks like this went well?

escapedcat avatar Nov 13 '24 13:11 escapedcat