commitlint icon indicating copy to clipboard operation
commitlint copied to clipboard

fix: use lodash

Open jmfrancois opened this issue 1 year ago • 3 comments

Description

The repository use lodash.xx packages which is discouraged. Please consider reading offical lodash recommendations: https://lodash.com/per-method-packages

Motivation and Context

I just want to help on the maintainance here so I have removed unmaintained packages and replace them by the latest lodash release.

During the work available lint and tests forced me to update two more files:

  • add a missing dependency on @commitlint/config-nx-scopes
  • fix a lint error on @commitlint/cli/src/cli.test.ts (test pass in both cases)

Usage examples

How Has This Been Tested?

I have run all existing script to try

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

jmfrancois avatar Feb 08 '24 12:02 jmfrancois

Thanks @jmfrancois ! Can you take care of the failing checks? Happy to merge this.

escapedcat avatar Feb 09 '24 09:02 escapedcat

Sure will do that next week

jmfrancois avatar Feb 10 '24 12:02 jmfrancois

We're using pure ESM now, so we should migrate to lodash-es instead.

JounQin avatar Feb 22 '24 16:02 JounQin

We're using pure ESM now, so we should migrate to lodash-es instead.

@jmfrancois Would you mind rebasing? And wdyt about using lodash-es?

escapedcat avatar Mar 02 '24 05:03 escapedcat

@jmfrancois ping?

knocte avatar Apr 08 '24 06:04 knocte

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Apr 08 '24 13:04 codesandbox-ci[bot]

I will not have the time sorry to investigate why so many tests are failing. I prefer close the PR for now

jmfrancois avatar Apr 23 '24 14:04 jmfrancois