commitlint icon indicating copy to clipboard operation
commitlint copied to clipboard

Published 20 hours ago • verified publisher icon conventional-changelog

Replace `globby` with `glob` in the project for smaller footprint

Open escapedcat opened this issue 4 years ago • 7 comments

Replace globby with glob in all commitlint-packages.

escapedcat avatar Dec 15 '20 02:12 escapedcat

Hello @escapedcat Can I contribute on this issue?

MadhaviMandalia avatar Jan 04 '22 09:01 MadhaviMandalia

Yeah, sure. Eventually just switching it should work ™️
Let me know if you run into issues.

escapedcat avatar Jan 04 '22 10:01 escapedcat

@escapedcat ok thanks. I have reviewed this issue. So instead of globby @11.0.1 we need to replace glob @7.1.6 in the whole project. Let me know is it correct?

MadhaviMandalia avatar Jan 04 '22 12:01 MadhaviMandalia

Looks like v7.2.0 is latest. You can use that directly.
Good luck :)

escapedcat avatar Jan 04 '22 12:01 escapedcat

Should I just remove globby v11.0.0, v11.0.1, v11.0.2, v11.0.4 to put only one glob?

image

MadhaviMandalia avatar Jan 04 '22 13:01 MadhaviMandalia

This is form the lock-file? No need to change that. Once you remove globby from all package.jsons and do a yarn the lock file should update itself. If other deps need globby that's still ok.

escapedcat avatar Jan 04 '22 13:01 escapedcat

Yes, Ok thanks for the suggestions. I have raised a PR #2952 please check and let me know if there is any change 👍

Thanks & Regards.

MadhaviMandalia avatar Jan 04 '22 14:01 MadhaviMandalia