forms-multiplier icon indicating copy to clipboard operation
forms-multiplier copied to clipboard

Multiplier does not apply form rules

Open radekdostal opened this issue 1 year ago • 2 comments

Tested with version 3.2.0.

$budgets = $form->addMultiplier('budgets', function(Container $budget, Form $form): void
{
  $budget->addText('price', 'Cena')
    ->setMaxLength(10)
    ->setRequired()
    ->addRule($form::FLOAT)
    ->addRule($form::MIN, NULL, 1);
});

E.g. for the value "10 000,00" the conversion to type float is not applied.

The same for the filter. The code inside the function is not called at all.

...
->addFilter(function ($value) {
  return str_replace([' ', ','], ['', '.'], $value)
})
...

Outside of the multiplier, the value is correctly converted to a float.

I think it is due to this: https://github.com/contributte/forms-multiplier/blob/v3.2.0/src/Multiplier.php#L206

It is fixed in version 3.3.0: https://github.com/contributte/forms-multiplier/blob/v3.3.0/src/Multiplier.php#L206

Could you please release a new version 3.2.1? Unfortunately I can't switch to Latte 3 yet. Thank you very much.

Related to: https://github.com/contributte/forms-multiplier/issues/68 https://github.com/contributte/forms-multiplier/pull/69

radekdostal avatar Jan 24 '23 17:01 radekdostal