forms-bootstrap icon indicating copy to clipboard operation
forms-bootstrap copied to clipboard

Published 20 hours ago • verified publisher icon contributte

bootstrap 5 code not valid

Open pytelCZ opened this issue 3 years ago • 4 comments

For example in bootstrap5 the form-inline for form tag is dropped, but it still generates it. So inline render mode for forms doesn't work.

pytelCZ avatar Jan 06 '22 12:01 pytelCZ

@pytelCZ could you provide at least HTML? like what it is now and what it should look like in one sample form and I'll add unit tests for it and fix it, but I'm not using bootstrap 5 ATM and do not have time to go in it more details.

dakorpar avatar Jan 07 '22 09:01 dakorpar

@pytelCZ You can send PR with fix.

stanislav-janu avatar Jan 11 '22 10:01 stanislav-janu

They changed the form work completely: dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline. In addition, a new display option has been added: floating forms which look cool. I don't think it's possible to do a simple example and therefore not a quick fix.

pytelCZ avatar Jan 12 '22 11:01 pytelCZ

I made only base support for BS5. (#53) Is enough for upgrade from BS4. For all features of BS5 not. That is known. If is your knowledge about BS5 features good, you can try make changes in this repo.

stanislav-janu avatar Jan 12 '22 11:01 stanislav-janu