datagrid icon indicating copy to clipboard operation
datagrid copied to clipboard

Check whether given row ID is valid HTML ID

Open repli2dev opened this issue 6 years ago • 2 comments

If not it will cause ajax malfunction (such as not refreshing rows...)

repli2dev avatar Feb 23 '18 09:02 repli2dev

@repli2dev And can you send a PR that will fix that?

paveljanda avatar Oct 05 '18 16:10 paveljanda

@paveljanda I did a little research and experimenting as I didn't know what value caused this... It was probably something like /Users/foo/bar, /Users/foo/bar bar or #abcd both fails.

However on other end this is not a problem of this library as they are not in some way valid (not in HTML4, not in HTML 4 and 5, not in HTML 4) and therefore nette.ajax.js fails on some of them.

In my opinion the library should not limit the usage in the name of some selected arbitrary library and therefore I would suggest only to add note to some places "That the domain of IDs is limited by the HTML4 and HTML5 standards as they are used in AJAX snippets, another limitations can (and will) come from AJAX snippet library (for example nette.ajax.js limits probably to HTML4)"

Ideas of places (as I was not able to find the documentation in this repository):

  • Implementation of custom DataSource
  • AJAX page

repli2dev avatar Oct 27 '18 09:10 repli2dev