apitte icon indicating copy to clipboard operation
apitte copied to clipboard

Published 20 hours ago • verified publisher icon contributte

Request header parameter fix

Open miranovy opened this issue 3 years ago • 5 comments

Header request parameter "X-Auth-Token" should be provided.

$request->getHeaders() return headers names with upper letters (e.g. X-Auth-Token) and condition on line 135 (https://github.com/contributte/apitte/blob/master/src/Mapping/RequestParameterMapping.php#L135) is false becouse $headerParameterName always contains parameter name (e.g. x-auth-token) with lower letters. Therefore, I converted everything to lowercase.

miranovy avatar Oct 04 '21 09:10 miranovy

Nice. Can you please add some tests?

f3l1x avatar Oct 04 '21 09:10 f3l1x

Added test containing header name in uppercase and lowercase letters

miranovy avatar Oct 04 '21 13:10 miranovy

@f3l1x Can you help me with failed static analysis under php 8.0?

miranovy avatar Oct 26 '21 13:10 miranovy

Can you please rebase it? I think it will be OK.

f3l1x avatar Feb 04 '22 16:02 f3l1x

Can you rebase it @miranovy?

f3l1x avatar Jul 22 '22 10:07 f3l1x

Resolved via https://github.com/contributte/apitte/pull/188

f3l1x avatar Sep 13 '22 16:09 f3l1x