github-action icon indicating copy to clipboard operation
github-action copied to clipboard

[BUG] Unrelated user is tagged with @ in comment

Open ivan opened this issue 3 years ago • 3 comments

Describe the bug

On a project I do not control, in https://github.com/exadel-inc/CompreFace/pull/543#issuecomment-852254987, the action seems to have inserted "@ivan" in the comment, causing GitHub to send an email to an unrelated ivan (me).

To Reproduce

I don't know, but "Ivan Kurnosau seems not to be a GitHub user" is probably related.

Expected behavior

Please don't @ unrelated GitHub users, it leads to undesired email from unrelated projects.

Screenshots

Screenshot 2021-06-02 073337

ivan avatar Jun 02 '21 07:06 ivan

Hi there, I'm a CompreFace repository contributor and looks like I know how to reproduce it. So real Ivan Kurnosau has such config for git on a local machine: user.email: [email protected] user.name: Ivan Kurnosau But his GitHub Account has another email: [email protected] So, cla-assistant didn't find such a user and just used a local user.name to tag a user But because user.name has space, it tagged @ivan We will try to fix it from our side - just add the correct email to the GitHub account. But this is definitely a bug, you shouldn't try to tag unknown users.

pospielov avatar Jun 02 '21 16:06 pospielov

Hi @ivan, I am really sorry that this GitHub action has sent you a unrelated email. I will fix this bug soon. @pospielov Thank you for the explanation :). You are absolutely right 😄.

ibakshay avatar Jun 06 '21 15:06 ibakshay

@pospielov : I believe this is still occurring, see here: https://github.com/silviogutierrez/reactivated/pull/222

silviogutierrez avatar Oct 02 '22 20:10 silviogutierrez