arduino-timer icon indicating copy to clipboard operation
arduino-timer copied to clipboard

src:arduino-timer: Remove WProgram.h include

Open skrobinson opened this issue 4 years ago • 2 comments

This header was renamed in Nov. 2011 and only Arduino IDE versions prior to v1.0 used that name.

Signed-off-by: Sean Robinson [email protected]

skrobinson avatar Nov 12 '20 17:11 skrobinson

Thanks for your contribution. I'm going to leave this open for a while for visibility.

I'm aware of people using the library outside of the Arduino IDE, and don't know how this change may affect them. This might have to wait until the next major version bump.

contrem avatar Nov 13 '20 17:11 contrem

Yes, I found this issue when building with a Makefile that does not have the ARDUINO define. While fixing the compile error, I realized the WProgram.h header was not relevant to a recent project and removed the version check, instead.

This may be enough of a change for others that it makes sense to hold off until 3.0.

skrobinson avatar Nov 16 '20 15:11 skrobinson

included in release 3.0.0

contrem avatar Feb 09 '23 01:02 contrem