james wolf
james wolf
@jimbojw I made a new PR integrating your concerns and making it dynamic: https://github.com/PAIR-code/facets/pull/119
let me know if that doesnt work
@jimbojw better? worse?
@jameswex can I get a ruling on the new PR? I actually had some new ideas for UI changes to the deep dive display that will work better for jupyter...
@jimbojw yeah, I was only making the change to that one file, I cant seem to figure out why github is having trouble displaying it but I merged my changes...
my changes were to figure out how to get github to display correctly, but it never did so I went back to my original code from the PR, which is...
@jimbojw I was trying to get the ipynb file to display correctly in github, it was the output html from that but it still doesnt display unfortunately, you can ignore...
@jimbojw I can do another PR without that if you want, just let me know
@jimbojw and @jameswex the new PR without the HTML file: https://github.com/PAIR-code/facets/pull/123
cool, glad you like it, looking forward to seeing what the new changes look like. The main reason I was thinking of this is just that it is somewhat difficult...