graphql-helix
graphql-helix copied to clipboard
create separate package for @graphql-helix/core
Hey there,
we have done our best to solve the package size issue. This may not be complete, especially around the deno packages.
Looking for some early feedback on this one 🤞🏻 @n1ru4l @talentlessguy @danielrearden
@n1ru4l is there anything I can do to move this forward?
@mosch, I did not have a look yet, but will on Thursday. Can you rebase upon master until then?
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/graphql-helix/graphql-helix/DUwDk1qFoZ7hKWmQNRTdXUCwiW1s
✅ Preview: https://graphql-helix-git-fork-launchport-separate-packge-graphql-helix.vercel.app
@mosch Shouldn't the be also a @graphql-helix/graphiql
package that exports the renderGraphiQL
and the shouldRenderGraphiQL
function? It is a bit inconsistent to me that shouldRenderGraphiQL
is still part of @graphql-helix/core
, while shouldRenderGraphiQL
is part of graphql-helix
.
Since @mosch probably will be out for a while, I might as well take this over.
I think your comment makes sense, and I'll happily move that function into @graphql-helix/graphiql
. Is there anything else we're missing to move this forward by the other reviewers (besides a merge/rebase)?
Thanks ✌️
edit: (don't know why vercel tests fail)
Deployment failed with the following error:
The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/graphql-helix/settings/billing.
Hey @dan-lee, sorry for letting this slip so long. Do you mind rebasing and finishing this PR? Let's finish this and release it.