graphql-helix icon indicating copy to clipboard operation
graphql-helix copied to clipboard

create separate package for @graphql-helix/core

Open mosch opened this issue 2 years ago • 9 comments

Hey there,

we have done our best to solve the package size issue. This may not be complete, especially around the deno packages.

Looking for some early feedback on this one 🤞🏻 @n1ru4l @talentlessguy @danielrearden

mosch avatar Nov 16 '21 11:11 mosch

@n1ru4l is there anything I can do to move this forward?

mosch avatar Nov 29 '21 13:11 mosch

@mosch, I did not have a look yet, but will on Thursday. Can you rebase upon master until then?

n1ru4l avatar Nov 29 '21 13:11 n1ru4l

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/graphql-helix/graphql-helix/DUwDk1qFoZ7hKWmQNRTdXUCwiW1s
✅ Preview: https://graphql-helix-git-fork-launchport-separate-packge-graphql-helix.vercel.app

vercel[bot] avatar Nov 30 '21 12:11 vercel[bot]

@mosch Shouldn't the be also a @graphql-helix/graphiql package that exports the renderGraphiQL and the shouldRenderGraphiQL function? It is a bit inconsistent to me that shouldRenderGraphiQL is still part of @graphql-helix/core, while shouldRenderGraphiQL is part of graphql-helix.

n1ru4l avatar Dec 02 '21 14:12 n1ru4l

Since @mosch probably will be out for a while, I might as well take this over. I think your comment makes sense, and I'll happily move that function into @graphql-helix/graphiql. Is there anything else we're missing to move this forward by the other reviewers (besides a merge/rebase)?

Thanks ✌️

edit: (don't know why vercel tests fail)

dan-lee avatar Dec 21 '21 21:12 dan-lee

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/graphql-helix/settings/billing.

vercel[bot] avatar Dec 21 '21 22:12 vercel[bot]

Hey @dan-lee, sorry for letting this slip so long. Do you mind rebasing and finishing this PR? Let's finish this and release it.

n1ru4l avatar Jul 08 '22 23:07 n1ru4l