`Bold` and `Faint` CSI changes a background color

[data-man]

Contour Terminal version

0.3.3-unreleased-master-a8ad3ed2

Installer source

Github: source code cloned

Operating System

Devuan

Architecture

x86-64

Other Software

No response

Steps to reproduce

• comment all colors in dim and bright sections in contour.yml
• uncomment:

# decoration "0" "Reset or normal"
# decoration "1" "Bold or increased intensity"
# decoration "2" "Faint, decreased intensity, or dim"
...

• run $ test/decoration.sh

Expected Behavior

Background color is unchanged.

Actual Behavior

Additional notes

No response

[christianparpart]

good catch, thx.

EDIT: it should only affect foreground color, to be honest, or nor color at all (that's a debate with a long history).

[christianparpart]

So bold colors are meant to be altered when bold_is_bright is set to `true.

Faint (dim) coloring indeed has a bug, especially with respect to default text and to background coloring.

[data-man]

Thank you! But... With draw_bold_text_with_bright_colors: true:

[christianparpart]

draw_bold_text_with_bright_colors alters the colors to be bright colors. that's the meaning of this option. The question is whether or not it should deal only with foreground color or also with background color.

[data-man]

I think a background color should not be changed.

[christianparpart]

done