Add includeUnstaged option to commit slash command
Description
I did debate adding an optional parameter, but thought it was better to be explicit, so that anyone using getDiff in the future can make a decision on whether to include unstaged changes or not. I've therefore updated other uses of getDiff to align with the previous behaviour, but we can change that here if we want to.
Closes #1893.
Checklist
- [x] The base branch of this PR is
dev, rather thanmain - [x] The relevant docs, if any, have been updated or created
@Patrick-Erichsen I know you mentioned adding an error message with this when no changes are staged. This is the current error message which still works with these changes: "No changes detected. Make sure you are in a git repository with current changes.". Do we think this is fine, or should we specifically mention staged changes?
@FozzieHi this looks solid! Just had a few naming convention comments. Great work overall 🚀
@FozzieHi any thoughts on the proposed changes here? Would love to get this merged for the next release!
Hey @Patrick-Erichsen, sorry been a bit busy. I may be able to take a look this weekend
Hey @FozzieHi, wanted to check in on this to avoid leaving up PRs for too long. Do you think you'll have the chance to look into this?
@sestinj I appreciate the reminder, just picking it up again now.
@Patrick-Erichsen You mentioned INCLUDE_UNSTAGED_DEFAULT a few times. Is there a particular file I should add the class boolean to?
Hi @FozzieHi , sorry for the delay here! I missed your reply.
I think it's fine to omit the INCLUDE_UNSTAGED_DEFAULT. This looks good as is, think we just need to merge dev in to fix the failing PR checks.
@Patrick-Erichsen No worries, merged in dev now. Reading through it again it all looks good to me, but I can do a quick test tomorrow unless you're able to get around to it before me.
Looks good to me, thanks for seeing this through! 🚀
Hi @FozzieHi, yesterday we shared some updates with our contributors about how we're aiming to improve the contribution process. Part of this included the addition of a Contributor License Agreement (CLA) to protect both contributors and the project. We're reaching out to ask that previous contributors sign it.
Could you please take a moment to sign, or if you have any questions send me a message? (either here or [email protected] would work)
To do so, you just need to post a comment below with the following text:
I have read the CLA Document and I hereby sign the CLA
❤️ Thank you for the work you've done on Continue, and let me know if you have any suggestions on how we can make the project even better!
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.