continue icon indicating copy to clipboard operation
continue copied to clipboard

Add includeUnstaged option to commit slash command

Open FozzieHi opened this issue 1 year ago • 7 comments

Description

I did debate adding an optional parameter, but thought it was better to be explicit, so that anyone using getDiff in the future can make a decision on whether to include unstaged changes or not. I've therefore updated other uses of getDiff to align with the previous behaviour, but we can change that here if we want to.

Closes #1893.

Checklist

  • [x] The base branch of this PR is dev, rather than main
  • [x] The relevant docs, if any, have been updated or created

FozzieHi avatar Aug 06 '24 22:08 FozzieHi

@Patrick-Erichsen I know you mentioned adding an error message with this when no changes are staged. This is the current error message which still works with these changes: "No changes detected. Make sure you are in a git repository with current changes.". Do we think this is fine, or should we specifically mention staged changes?

FozzieHi avatar Aug 06 '24 22:08 FozzieHi

@FozzieHi this looks solid! Just had a few naming convention comments. Great work overall 🚀

Patrick-Erichsen avatar Aug 06 '24 23:08 Patrick-Erichsen

@FozzieHi any thoughts on the proposed changes here? Would love to get this merged for the next release!

Patrick-Erichsen avatar Aug 21 '24 18:08 Patrick-Erichsen

Hey @Patrick-Erichsen, sorry been a bit busy. I may be able to take a look this weekend

FozzieHi avatar Aug 21 '24 18:08 FozzieHi

Hey @FozzieHi, wanted to check in on this to avoid leaving up PRs for too long. Do you think you'll have the chance to look into this?

sestinj avatar Sep 29 '24 02:09 sestinj

@sestinj I appreciate the reminder, just picking it up again now.

FozzieHi avatar Sep 29 '24 14:09 FozzieHi

@Patrick-Erichsen You mentioned INCLUDE_UNSTAGED_DEFAULT a few times. Is there a particular file I should add the class boolean to?

FozzieHi avatar Sep 29 '24 14:09 FozzieHi

Hi @FozzieHi , sorry for the delay here! I missed your reply.

I think it's fine to omit the INCLUDE_UNSTAGED_DEFAULT. This looks good as is, think we just need to merge dev in to fix the failing PR checks.

Patrick-Erichsen avatar Oct 14 '24 17:10 Patrick-Erichsen

@Patrick-Erichsen No worries, merged in dev now. Reading through it again it all looks good to me, but I can do a quick test tomorrow unless you're able to get around to it before me.

FozzieHi avatar Oct 14 '24 21:10 FozzieHi

Looks good to me, thanks for seeing this through! 🚀

Patrick-Erichsen avatar Oct 14 '24 21:10 Patrick-Erichsen

Hi @FozzieHi, yesterday we shared some updates with our contributors about how we're aiming to improve the contribution process. Part of this included the addition of a Contributor License Agreement (CLA) to protect both contributors and the project. We're reaching out to ask that previous contributors sign it.

Could you please take a moment to sign, or if you have any questions send me a message? (either here or [email protected] would work)

To do so, you just need to post a comment below with the following text:

I have read the CLA Document and I hereby sign the CLA

❤️ Thank you for the work you've done on Continue, and let me know if you have any suggestions on how we can make the project even better!

sestinj avatar May 15 '25 18:05 sestinj


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar May 15 '25 18:05 github-actions[bot]