operational-ui icon indicating copy to clipboard operation
operational-ui copied to clipboard

OperationalContext - seperate logic from presentaion

Open JoshRosenstein opened this issue 5 years ago • 5 comments

After realizing i couldn't use some components without having them wrapped in OperationalUI and then reading over useOperationalContext Feature,

Whenever you choose to refactor some of the components like (Button, Breadcrumb,Logo etc), I think it would be best to separate out the logic from UI components. I dont need to preach the reasons why, but i thought after seeing that PR, that would be a good time to do it when those get refactored.

Also you can even take it a step further and breakdown and export everything like Uber/baseui 😄

JoshRosenstein avatar Mar 01 '19 05:03 JoshRosenstein

Great idea! Do you have a little bit more concrete information about which components would be touched?

TejasQ avatar Mar 01 '19 09:03 TejasQ

JoshRosenstein avatar Mar 01 '19 11:03 JoshRosenstein

This is a great idea! It's actually a continuation (IMO) of #911. Let's do it and HOOKS ALL THE THINGS! Wanna collab?

TejasQ avatar Mar 01 '19 17:03 TejasQ

Yeah saw that and why i brought it up as it would be a perfect time to knock out 2 birds with one stone. I gotta get used to correctly linking my refs haha.

JoshRosenstein avatar Mar 01 '19 20:03 JoshRosenstein

I think this is closable since we merged #911, right, @JoshRosenstein?

TejasQ avatar Jun 23 '19 02:06 TejasQ