operational-ui
operational-ui copied to clipboard
Add breadcrumb to Page
So I'm wondering if it makes sense to add Breadcrumbs
inside page such that when Page
is given a breadcrumb
prop, it uses Breadcrumbs
and Breadcrumb
internally like so:
<Page
breadcrumb={
[
{ label: "Start", to: "/" },
{ label: "Here", to: "/here" }
]
}
/>
The drawback I see is that it couples Breadcrumbs
and Page
and makes Page
a bit more complex and fundamentally disrupts a nice composition model in userland.
That said, something like this:
isn't really attainable in userland without adding this prop to Page and significant UI/CSS hackery. Instead, one would end up with something like this out of the box:
So the question finally is: should we add this prop or not?
Great. Let's do it.