RFC: Focus and hover styles on ContextMenuItems

[TejasQ]

I feel the current style of focus and hover of ContextMenuItem is a little too out of place. It's bright and blue and attracts too much attention.

• It also doesn't really conform to our internal designs
• It also used to be a lot more subtle (and in my opinion nicer)

For these reasons, I propose restyling the hover/focus states to be the following:

Hover

Focus

If we agree, I'll go ahead and open a PR with changes that implement this adjustment.

RFC @kemal-contiamo @micha-f @contiamo/frontend

[kemal-contiamo]

I feel the current style of focus and hover of ContextMenuItem is a little too out of place. It's bright and blue and attracts too much attention.

• It also doesn't really conform to our internal designs
• It also used to be a lot more subtle (and in my opinion nicer)

For these reasons, I propose restyling the hover/focus states to be the following:

Hover

Focus

If we agree, I'll go ahead and open a PR with changes that implement this adjustment.

RFC @kemal-contiamo @micha-f @contiamo/frontend

@TejasQ would your proposed changes effecting all dropdown regardless of where they're being used?

[TejasQ]

Yes. Please be aware that this is how all dropdowns looked before.

[kemal-contiamo]

@TejasQ I like the subtleness, but I would prefer to keep what's already being designed (the new one). One of the main reason is that we have this combo-dropdown (with custom text field) - look at the background color of the "custom":

The other reason is that I am deliberately making our focus and hover state a bit "catchy", so that it is more usable (think of users that don't have such a good eyes like ours ;)).

[TejasQ]

I hear what you're saying, but bigger list items look a little weird: see the second example here. What do we do in this case?

[kemal-contiamo]

I hear what you're saying, but bigger list items look a little weird: see the second example here. What do we do in this case?

Is it weird because of its narrow width you mean? or weird because the way focus and hover state looks in those menu?

[TejasQ]

Weird because it's super blue there but not super blue here even though they're conceptually the same thing.

[TejasQ]

@kemal-contiamo what conclusion did we come to here?