forma-36 icon indicating copy to clipboard operation
forma-36 copied to clipboard

feat(paint-brush-icon): add new icon for paint brush

Open ethan-ozelius-contentful opened this issue 1 year ago • 3 comments

Purpose of PR

As part of an effort to improve the UX of forma36's <EntityCard>, by supporting Experiences, as an entity type, this PR adds the paintbrush icon which will be the default icon for Experiences in the <EntityCard>. However, since Entity List has a dependency on f36-icons, the icon has to be added before it can be referenced anywhere else.

This Icon technically already exists in [user_interface] navbar (see screenshot)(https://github.com/contentful/user_interface/blob/master/src/javascripts/features/navigation/icons/BrushIcon.tsx), but is obviously not accessible to forma.

Screenshot 2024-07-05 at 1 33 08 PM

Screenshot of Icon

Screenshot 2024-07-05 at 1 02 15 PM

PR Checklist

  • [x] I have read the relevant readme.md file(s)
  • [x] All commits follow our Git commit message convention
  • [x] Tests are added/updated/not required
  • [x] Tests are passing
  • [x] Storybook stories are added/updated/not required
  • [x] Usage notes are added/updated/not required
  • [x] Has been tested based on Contentful's browser support
  • [x] Doesn't contain any sensitive information

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jul 22, 2024 2:47pm

vercel[bot] avatar Jul 05 '24 19:07 vercel[bot]

🦋 Changeset detected

Latest commit: 44dccff22195fdfa6f8e637f292a81bd51fc81d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@contentful/f36-entity-list Patch
@contentful/f36-icons Minor
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-header Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-navbar Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch
@contentful/f36-image Patch
@contentful/f36-avatar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 05 '24 19:07 changeset-bot[bot]

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 136.69 KB (-1.16% 🔽) 2.8 s (-1.16% 🔽) 740 ms (+5.61% 🔺) 3.5 s
Module 132.94 KB (-1.23% 🔽) 2.7 s (-1.23% 🔽) 865 ms (+15.48% 🔺) 3.6 s

github-actions[bot] avatar Jul 05 '24 19:07 github-actions[bot]

Hello Ethan,

I am sorry you missed this. We introduced the icon as part of the v5 alpha icons and you can already use it.

import { PaintBrushIcon } from ‘@contentful/f36-icons-alpha’;

We introduced it in the updated navigation (internal beta as we speak).

We migrated all v4 icons to use v5, but it was missed in Experiences because it was a custom SVG, which the codemod does not support.

default active

cf-remylenoir avatar Jul 08 '24 12:07 cf-remylenoir