forma-36 icon indicating copy to clipboard operation
forma-36 copied to clipboard

Published 20 hours ago • verified publisher icon contentful

feat(icons): generate tsx from svg

Open mshaaban0 opened this issue 2 years ago • 5 comments

Purpose of PR

  • add SVGR to f36-icons
  • Add build:icon command to f36-icons package to generate tsx react component from SVG files

Todo

[ ] The command is currently broken because the template from SVGR expects a valid JSX element, and we have a custom one. Refactor the icons component or make it work :)

PR Checklist

  • [ ] I have read the relevant readme.md file(s)
  • [ ] All commits follow our Git commit message convention
  • [ ] Tests are added/updated/not required
  • [ ] Tests are passing
  • [ ] Storybook stories are added/updated/not required
  • [ ] Usage notes are added/updated/not required
  • [ ] Has been tested based on Contentful's browser support
  • [ ] Doesn't contain any sensitive information

mshaaban0 avatar Feb 15 '23 18:02 mshaaban0