forma-36 icon indicating copy to clipboard operation
forma-36 copied to clipboard

feat(f36-codemod): ESM

Open denkristoffer opened this issue 2 years ago • 9 comments

Purpose of PR

ESM codemod to unblock package upgrades.

denkristoffer avatar Oct 04 '22 13:10 denkristoffer

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 9, 2024 0:53am

vercel[bot] avatar Oct 04 '22 13:10 vercel[bot]

🦋 Changeset detected

Latest commit: 53d087b9f415a6cf4130a29f5941466066625cf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@contentful/f36-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 04 '22 13:10 changeset-bot[bot]

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 130.53 KB (0%) 2.7 s (0%) 233 ms (-24.89% 🔽) 2.9 s
Module 127.46 KB (0%) 2.6 s (0%) 280 ms (-24.76% 🔽) 2.9 s

github-actions[bot] avatar Oct 04 '22 13:10 github-actions[bot]

I tried this out locally and it seemed to work fine even with node 14. @massao are there any gotchas or specific situations you think I should test before merging?

denkristoffer avatar Oct 18 '22 07:10 denkristoffer

I tried this out locally and it seemed to work fine even with node 14. @massao are there any gotchas or specific situations you think I should test before merging?

maybe just running it against some other repos?? also test that it works with the arguments and with the wizard, other than that, I think it should be fine if it's working locally

massao avatar Oct 24 '22 10:10 massao

btw, should we mark this as a major change on the codemod?

massao avatar Oct 24 '22 12:10 massao

I ran the wizard on a part of our web app. Will try out with arguments.

denkristoffer avatar Oct 24 '22 12:10 denkristoffer

Marking pull request as stale since there was no activity for 30 days

github-actions[bot] avatar Nov 24 '22 07:11 github-actions[bot]

Marking pull request as stale since there was no activity for 30 days

github-actions[bot] avatar Feb 17 '24 07:02 github-actions[bot]