forma-36 icon indicating copy to clipboard operation
forma-36 copied to clipboard

🐛 Bug - Forma 36 React - Tables that are not forma 36 components change colour on hover.

Open samgoulden28 opened this issue 4 years ago • 7 comments

Forma 36 bug report

Summary

Hovering over any TD element in tables that are not forma 36 components changes their background color to white. This is particularly frustrating as I am attempting to build a contentful UI extension making use of the fullcalendar npm module.

Due to the rules:

tr:hover td:not(.TableCell__TableCell--head___3AHws){background-color:#f7f9fa}.

and

tr:hover td:not(.TableSortingLabel__TableCell--head___yxhXj){background-color:#f7f9fa}

Hovering over any TD element, even those that are not related to forma 36, will change their background color to #f7f9fa.

https://codesandbox.io/s/epic-mccarthy-yoezd?file=/src/App.js

Environment

"@contentful/forma-36-react-components": "^3.98.4",
"@contentful/forma-36-tokens": "^0.9.4",

Chrome Version 94.0.4606.81 (Official Build) (x86_64)

Steps to reproduce

See code sandbox https://codesandbox.io/s/epic-mccarthy-yoezd?file=/src/App.js

Expected results

I expect only forma 36 components to adhere to this css rule.

Actual results

I expected background colour of TDs not to change

samgoulden28 avatar Oct 25 '21 19:10 samgoulden28

Thanks for reporting @samgoulden28, we will get this fixed.

denkristoffer avatar Oct 26 '21 08:10 denkristoffer

@denkristoffer is there still a fix planned for this or can we close this?

Lelith avatar May 30 '22 07:05 Lelith

Hey, Can I work on this issue?

nawed2611 avatar Jun 30 '22 18:06 nawed2611

@nawed2611 Absolutely, that would be lovely 🙂

denkristoffer avatar Jul 05 '22 11:07 denkristoffer

I suppose this is the file that needs changing

nawed2611 avatar Jul 15 '22 20:07 nawed2611

I'll create a PR for this

nawed2611 avatar Jul 15 '22 20:07 nawed2611

Marking issue as stale since there was no acitivty for 30 days

github-actions[bot] avatar Aug 15 '22 07:08 github-actions[bot]

Although this bug is still valid I'll go ahead and close this issue as the v3 package is not maintained by Contentful anymore. We're still happy to accept external contributions for this issue though!

denkristoffer avatar Aug 26 '22 08:08 denkristoffer