field-editors icon indicating copy to clipboard operation
field-editors copied to clipboard

Published 20 hours ago • verified publisher icon contentful

💡 Proposal - Improve rich-text code visability

Open lukasoppermann opened this issue 5 years ago • 4 comments

The problem

Inline code is really hard to spot, due to only slightly changing the appearance compared to normal text.

Screenshot 2020-10-19 at 14 40 14

Three works comment, description and remarks are actually code elements.

The proposed solution

Add a (grey) background around the element to more strongly differentiate it, just like on github.

E.g. just text vs. a code element

Breaking changes

  • none

lukasoppermann avatar Oct 19 '20 12:10 lukasoppermann

Nice catch! 👍

joaoramos avatar Oct 20 '20 08:10 joaoramos

Definitely a good suggestion! Some extra work will be needed for the rich text editor though - it appears that these styles are hard-coded at the moment and don't come from the F36 component - https://github.com/contentful/field-editors/blob/acee0da7ad982a104e8567ae6b67f2a894ef86dc/packages/rich-text/src/plugins/shared/MarkPlugin.js#L18-L20

m10l avatar Oct 20 '20 11:10 m10l

Marking issue as stale since there was no acitivty for 30 days

github-actions[bot] avatar Aug 11 '22 07:08 github-actions[bot]

@m10l is this fixed? Can this be closed?

lukasoppermann avatar Aug 11 '22 07:08 lukasoppermann