contentful.js icon indicating copy to clipboard operation
contentful.js copied to clipboard

refactor: turn into dual node package with additional browser bundle

Open axe312ger opened this issue 1 year ago • 3 comments

Requires https://github.com/contentful/contentful-sdk-core/pull/438

  • [x] remove node (minified) bundle
  • [x] make available in cjs (as bundle for node without ESM support)
  • [x] make available in esm
  • [x] support ESM only dependencies
  • [x] support browser plain + minified
  • [x] switch from jest to vitest
  • [x] switch to rollup from webpack

Will fix:

  • https://github.com/contentful/contentful.js/issues/2131
  • https://github.com/contentful/contentful.js/issues/2122
  • https://github.com/contentful/contentful.js/pull/2130
  • https://github.com/contentful/contentful.js/issues/1873
  • https://github.com/contentful/contentful.js/issues/2214

axe312ger avatar Feb 22 '24 17:02 axe312ger

Green tests 😱✅

Thank you @mgoudy91 for publishing the updated esm compatible SDK-CORE :)

axe312ger avatar Jul 13 '24 10:07 axe312ger

Looks like there's some conflicts as well, I started taking a look but I think it's going to take more time for me to gain context than I thought. Let me know if you'd like help with that and I can take a look

mgoudy91 avatar Jul 16 '24 14:07 mgoudy91

@mgoudy91

  1. release: I am not sure how it would release, I think you/we have to do the same as you did here https://github.com/contentful/contentful-sdk-core/pull/438 - but we should release it as new major/breaking version, starting with an alpha version for public testing
  2. legacy config: the jest.config is gone
  3. legacy commented out code: can't find any commented out code, can you point me to where you did see it?
  4. conflicts: resolved!

axe312ger avatar Jul 18 '24 12:07 axe312ger