contentful.js icon indicating copy to clipboard operation
contentful.js copied to clipboard

test: make package json command check min files

Open Techn1x opened this issue 1 year ago • 3 comments

Summary

See https://github.com/contentful/contentful.js/issues/1936

Description

I am hopeful that this can be used as a failing test (circle CI should run npm run build which will run these check commands and fail)

Screenshots (if appropriate):

Screenshot 2024-01-19 at 8 34 12 pm

Techn1x avatar Jan 19 '24 10:01 Techn1x

@marcolink is this useful or should I close it?

Techn1x avatar Feb 05 '24 02:02 Techn1x

cc @mgoudy91

marcolink avatar Feb 06 '24 08:02 marcolink

Would be great to see this fixed for a patch version. I did give it a go, but was only able to come up with the failing test.

Techn1x avatar Feb 19 '24 04:02 Techn1x

This will be included in #2164

See: https://github.com/contentful/contentful.js/pull/2164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

axe312ger avatar Apr 25 '24 09:04 axe312ger

Thankyou! Can confirm underlying issue resolved in 10.9.0+

Techn1x avatar May 03 '24 03:05 Techn1x