contentful-migration icon indicating copy to clipboard operation
contentful-migration copied to clipboard

Published 20 hours ago • verified publisher icon contentful

makeRequest and dry run

Open florian-milky opened this issue 4 years ago • 1 comments

Expected Behavior

makeRequest is executed when the migration has been validated and confirmed

Actual Behavior

makeRequest runs when the migration is validated

Possible Solution

Steps to Reproduce

  1. write a migration
  2. use makeRequest
  3. run the migration
  4. observe that makeRequest ran even though you still haven't chosen to apply the migration in the cli

Context

Environment

  • Node Version:
  • Package Manager Version:
  • Operating System:
  • Package Version:

florian-milky avatar Feb 12 '21 16:02 florian-milky

Yes, I even have looked at using the context and wiring up getClient, but having the migrations seed pass some form of flag even to allow for developer conditional execution would be helpful -- i.e. pass if it is committing the change or validating, so it is safe to run / does not have side effects

nteague22 avatar Oct 18 '22 15:10 nteague22