ContentfulBundle icon indicating copy to clipboard operation
ContentfulBundle copied to clipboard

The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final.

Open dbebawy-modus opened this issue 2 years ago • 3 comments

  1. The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Contentful\ContentfulBundle\Command\Delivery\InfoCommand".
  2. The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Contentful\ContentfulBundle\Command\Delivery\DebugCommand".

Resources:

  • https://github.com/rectorphp/rector-symfony/blob/main/docs/rector_rules_overview.md#commandpropertytoattributerector
  • https://symfony.com/doc/current/console.html

dbebawy-modus avatar Sep 16 '22 19:09 dbebawy-modus

Fixed in #62.

svenluijten avatar Dec 29 '22 18:12 svenluijten

v7.2 somewhat addresses this, but we can't switch to the new syntax yet as it's not supported in PHP7 and therefore not in Symphony 5.4.

Sebb767 avatar Jan 21 '23 15:01 Sebb767

@Sebb767 What is the new syntax if you're on PHP8 ?

Ctucker9233 avatar Jan 30 '23 20:01 Ctucker9233