contentful.ex icon indicating copy to clipboard operation
contentful.ex copied to clipboard

Published 20 hours ago • verified publisher icon contentful-userland

Links of links don't resolve properly

Open stavro opened this issue 6 years ago • 3 comments

I have a blog post -> author -> image relationship. When requesting the blog post, both the author and images show up in the includes field in the resposne, but the resolve logic in this library doesn't flatten it out properly, and then image source is lost.

VCR'd Fixture: https://gist.github.com/stavro/fb38c303017549feb07e51f4b7665eb0

Expected: Be able to access the author's image.

Actual: Image is not available after this library parses the response. It is in the response though.

stavro avatar Oct 11 '17 03:10 stavro

@floriank should this issue be closed? I noticed the associated PR was, because this issue was based on old code?

WillRochaThomas avatar Jun 30 '23 14:06 WillRochaThomas

I think my PR will fix this for all types of links going forward https://github.com/contentful-userland/contentful.ex/pull/181

WillRochaThomas avatar May 06 '24 16:05 WillRochaThomas

PR #181 been merged now, so this issue should be gone @floriank. Given it's been 7 years, I'm not sure whether @stavro still needs this 😂, I think it can be closed though.

WillRochaThomas avatar Jun 26 '24 09:06 WillRochaThomas