c2pa-rs icon indicating copy to clipboard operation
c2pa-rs copied to clipboard

Add GIF support

Open ok-nick opened this issue 1 year ago • 2 comments

Changes in this pull request

Adds GIF support.

Related Issues

  • Completes #476
  • Partially completes #394

WIP Priorities

  • [x] Parse entire GIF past pre-image-data block extensions
    • [x] Enables box hashing
    • [x] Completes XMP support (need to search pre and post block extensions)
  • [x] Block extension parser should be incremental (via iterator)
    • [x] It should also iterate blocks past pre-image-data as described above
  • [x] ~~Data hash location for XMP block~~
  • [x] Add unit tests
    • [x] Composed manifest refs
    • [x] ~~Asset patches~~
    • [x] Data hash locations
    • [x] Box hash locations
    • [x] Remote refs

Checklist

  • [x] This PR represents a single feature, fix, or change.
  • [x] All applicable changes have been documented.
  • [ ] Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

ok-nick avatar Jun 21 '24 18:06 ok-nick

Looks good. Just address the build issues and I can approve.

mauricefisher64 avatar Jul 08 '24 19:07 mauricefisher64

@mauricefisher64 Build issue is caused by an update in nightly toolchain, fixed in #498

ok-nick avatar Jul 08 '24 19:07 ok-nick