contenta_angular icon indicating copy to clipboard operation
contenta_angular copied to clipboard

Consistent heights for cards

Open mrjmd opened this issue 7 years ago • 2 comments

Sometimes our recipe list cards line up and look perfect:

image

But oftentimes the heights are off:

image

Even if the images / text length isn't quite the same, let's keep the height of the overall card consistent.

mrjmd avatar Jul 22 '17 15:07 mrjmd

The problem here sounds like its the missing "difficulty" in that middle recipe..I don't know if thats a bug on the backend. Fixing every height is also not a great solution.

Right now there are two main problems around this :

1 ) Super inconsistent thumbnails. This has been discussed in the main channel, as soon as we start using proper images and use image cache this should go away. We are mitigating this with what to me is a super hack..but at least makes it look ok.

2 ) Sometimes missing information comes..and we have to figure out if that is normal or if its a bug on a specific recipe (no image, no title, no tag, no time for example..we need to figure out the possible variations of a recipe card basically)

I will check in the main channel about these two topics. Cause having to make a fix height for tags, card, images etc..makes it really "hardcoded" which is not great.

joaogarin avatar Jul 22 '17 17:07 joaogarin

Yeah, my screenshots were a bad example but it's definitely happening on some rows without the "difficulty" problem. So this is not just an issue with missing information.

But I do see your point about hard coding.

mrjmd avatar Jul 22 '17 18:07 mrjmd