docs icon indicating copy to clipboard operation
docs copied to clipboard

Make all hook params consistent

Open Tastaturberuf opened this issue 5 years ago • 5 comments

Tastaturberuf avatar May 25 '20 09:05 Tastaturberuf

I would like to stay consistent. In one hook we now have ModuleModel $model and Module $module.

So here it should either be PageModel $model and PageRegular $page or PageModel $pageModel and PageRegular $pageRegular.

fritzmg avatar May 25 '20 09:05 fritzmg

Ah i know what you mean. i will check all hooks and push it in this PR. My goal is to be consistent too.

Tastaturberuf avatar May 25 '20 10:05 Tastaturberuf

Here is an overview with all Contao hooks: https://gist.github.com/Tastaturberuf/8851fc3348dcc229f4a49d81bc9220d0

On first sign i think we should suffix all models with Model to make clear what it is.

e.g. https://docs.contao.org/dev/reference/hooks/getPageLayout/ https://docs.contao.org/dev/reference/hooks/getFrontendModule/

Tastaturberuf avatar May 28 '20 11:05 Tastaturberuf