core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon contao

New templates and template handling for events

Open Aybee opened this issue 9 years ago • 13 comments

The template names

  • event_full
  • event_list
  • event_upcoming
  • event_teaser

are not meaningfull. And templates for eventlists should not get shown when eventreader is selected and vice versa as variables of both modules are different.

We only need a template eventlist_default and eventreader_default. Those templates should output most of the variables e.g.

List:

  • headline
  • teaser
  • teaser image
  • details (if no teaser or maybe always and then shortened by \StringUtil::substrHtml())

Reader:

  • headline
  • teaser (if no details)
  • teaser image
  • details

We should discuss which variables are most reasonable. Those default templates should be ment for easy customization by removing unwanted output variables.

Aybee avatar Sep 09 '16 12:09 Aybee

I think "list" doesn't need details - this would be confusing and performance could suffer. For compatibility reasons, the new *_default templates could exist parallel to the existing templates, but the *_default temlates should really be DEFAULT, when selecting a template.

I suggest to add all variables to list as well as reader, except for "details" in list, as mentioned above. The easiest way to get rid of unnecessary information is CSS and everyone setting up a website with contao should be able to define the proper CSS styles. Of course it's better to edit the template, but there are people out there who rather want to keep things as simple as possible.

marebe1602 avatar Sep 09 '16 13:09 marebe1602

@Aybee Aren't the variables the same now? Which are different?

fritzmg avatar Sep 09 '16 15:09 fritzmg

I think "list" doesn't need details - this would be confusing and performance could suffer.

@marebe1602 the details are loaded on demand inside the template. Performance won't suffer if you don't echo the details.

fritzmg avatar Sep 09 '16 15:09 fritzmg

@fritzmg yes, I know, but if you are afraid of PHP fragments and templates, the details would still be echoed, even if they are not needed. I always try to imagine a user, who knows how to use a mouse and is capable of a little html and css. A wide-spread CMS has to deal with those guys. They might be the majority out there, which makes them important.

marebe1602 avatar Sep 11 '16 08:09 marebe1602

I don't understand what you mean. If the user uses a template where the details are echoed, he wants the details to be echoed, otherwise he wouldn't use a template where the details are echoed.

fritzmg avatar Sep 11 '16 21:09 fritzmg

ok, let's get back to the orignal point: I think details from tl_content should not be part of the new eventlist_default template, because it's the purpose of teaser and image to provide a preview of the details within list view. Shortening the tl_content html by \StringUtil::substrHtml() as proposed by Aybee would mean, that tl_content has to be searched and processed for every list item.

marebe1602 avatar Sep 12 '16 07:09 marebe1602

You should be able to echo the details of a news or event element, if you want. Restricting it depending on the module does not make sense to me.

Regarding the original issue: I was wrong, there are (still) differences of the available template variables between the different modules.

fritzmg avatar Sep 12 '16 07:09 fritzmg

the standard case is to show teaser in list and details in reader after hitting "read more". Your proposal makes it necessary to edit template even if you want to have it "standard" way. If "event_full" was selectable in list module, you could use that one if you really need details in your list.

marebe1602 avatar Sep 12 '16 08:09 marebe1602

What proposal are you referring to?

fritzmg avatar Sep 12 '16 08:09 fritzmg

You should be able to echo the details of a news or event element, if you want. Restricting it depending on the module does not make sense to me.

The idea of Aybee was to only have two templates, one for list and one for reader. I suggested keeping the old ones, too for compatibility reasons. eventlist_default should not contain details, but it should be possible to select "event_full" for lists. Another idea: Maybe a new parameter "show details" in eventlist module could tell, if tl_content details should be loaded by eventlist_default template. Then you wouldn't have to edit the template and would still be able to choose.

marebe1602 avatar Sep 12 '16 08:09 marebe1602

My post referred to the possibility of echoing the details - not what is in templates by default.

The details should be available in any template.

You do not need a parameter called "show details". If you want to echo the details, you simply echo the details.

And you can still choose between default template anyway.

fritzmg avatar Sep 12 '16 08:09 fritzmg

I agree. The details variable should, of course, be available in any template.

marebe1602 avatar Sep 12 '16 08:09 marebe1602

@fritzmg Aren't the variables the same now? Which are different?

Not easy to debug. Here the plain variables of $this->arrData, no objects, no arrays. View with your diff tool.

[11-Sep-2016 18:38:00] 

file: /home/www/_c35/templates/event_list.html5 (line 16)

[addBefore] => 1
[addEnclosure] =>
[addImage] => 1
[addTime] => 1
[alias] => contao-north-day-10
[allRecurrences] => a:22:{i:1462485600;a:4:{s:9:"int_start";s:10:"1462485600";s:7:"int_end";i:1462571999;s:9:"str_start";s:16:"06.05.2016 00:00";s:7:"str_end";s:16:"06.05.2016 23:59";}i:1494021600;a:4:{s:9:"int_start";i:1494021600;s:7:"int_end";i:1494107999;s:9:"str_start";s:16:"06.05.2017 00:00";s:7:"str_end";s:16:"06.05.2017 23:59";}i:1525557600;a:4:{s:9:"int_start";i:1525557600;s:7:"int_end";i:1525643999;s:9:"str_start";s:16:"06.05.2018 00:00";s:7:"str_end";s:16:"06.05.2018 23:59";}i:1557093600;a:4:{s:9:"int_start";i:1557093600;s:7:"int_end";i:1557179999;s:9:"str_start";s:16:"06.05.2019 00:00";s:7:"str_end";s:16:"06.05.2019 23:59";}i:1588716000;a:4:{s:9:"int_start";i:1588716000;s:7:"int_end";i:1588802399;s:9:"str_start";s:16:"06.05.2020 00:00";s:7:"str_end";s:16:"06.05.2020 23:59";}i:1620252000;a:4:{s:9:"int_start";i:1620252000;s:7:"int_end";i:1620338399;s:9:"str_start";s:16:"06.05.2021 00:00";s:7:"str_end";s:16:"06.05.2021 23:59";}i:1651788000;a:4:{s:9:"int_start";i:1651788000;s:7:"int_end";i:1651874399;s:9:"str_start";s:16:"06.05.2022 00:00";s:7:"str_end";s:16:"06.05.2022 23:59";}i:1683324000;a:4:{s:9:"int_start";i:1683324000;s:7:"int_end";i:1683410399;s:9:"str_start";s:16:"06.05.2023 00:00";s:7:"str_end";s:16:"06.05.2023 23:59";}i:1714946400;a:4:{s:9:"int_start";i:1714946400;s:7:"int_end";i:1715032799;s:9:"str_start";s:16:"06.05.2024 00:00";s:7:"str_end";s:16:"06.05.2024 23:59";}i:1746482400;a:4:{s:9:"int_start";i:1746482400;s:7:"int_end";i:1746568799;s:9:"str_start";s:16:"06.05.2025 00:00";s:7:"str_end";s:16:"06.05.2025 23:59";}i:1778018400;a:4:{s:9:"int_start";i:1778018400;s:7:"int_end";i:1778104799;s:9:"str_start";s:16:"06.05.2026 00:00";s:7:"str_end";s:16:"06.05.2026 23:59";}i:1809554400;a:4:{s:9:"int_start";i:1809554400;s:7:"int_end";i:1809640799;s:9:"str_start";s:16:"06.05.2027 00:00";s:7:"str_end";s:16:"06.05.2027 23:59";}i:1841176800;a:4:{s:9:"int_start";i:1841176800;s:7:"int_end";i:1841263199;s:9:"str_start";s:16:"06.05.2028 00:00";s:7:"str_end";s:16:"06.05.2028 23:59";}i:1872712800;a:4:{s:9:"int_start";i:1872712800;s:7:"int_end";i:1872799199;s:9:"str_start";s:16:"06.05.2029 00:00";s:7:"str_end";s:16:"06.05.2029 23:59";}i:1904248800;a:4:{s:9:"int_start";i:1904248800;s:7:"int_end";i:1904335199;s:9:"str_start";s:16:"06.05.2030 00:00";s:7:"str_end";s:16:"06.05.2030 23:59";}i:1935784800;a:4:{s:9:"int_start";i:1935784800;s:7:"int_end";i:1935871199;s:9:"str_start";s:16:"06.05.2031 00:00";s:7:"str_end";s:16:"06.05.2031 23:59";}i:1967407200;a:4:{s:9:"int_start";i:1967407200;s:7:"int_end";i:1967493599;s:9:"str_start";s:16:"06.05.2032 00:00";s:7:"str_end";s:16:"06.05.2032 23:59";}i:1998943200;a:4:{s:9:"int_start";i:1998943200;s:7:"int_end";i:1999029599;s:9:"str_start";s:16:"06.05.2033 00:00";s:7:"str_end";s:16:"06.05.2033 23:59";}i:2030479200;a:4:{s:9:"int_start";i:2030479200;s:7:"int_end";i:2030565599;s:9:"str_start";s:16:"06.05.2034 00:00";s:7:"str_end";s:16:"06.05.2034 23:59";}i:2062015200;a:4:{s:9:"int_start";i:2062015200;s:7:"int_end";i:2062101599;s:9:"str_start";s:16:"06.05.2035 00:00";s:7:"str_end";s:16:"06.05.2035 23:59";}i:2093637600;a:4:{s:9:"int_start";i:2093637600;s:7:"int_end";i:2093723999;s:9:"str_start";s:16:"06.05.2036 00:00";s:7:"str_end";s:16:"06.05.2036 23:59";}i:2125173600;a:4:{s:9:"int_start";i:2125173600;s:7:"int_end";i:2125259999;s:9:"str_start";s:16:"06.05.2037 00:00";s:7:"str_end";s:16:"06.05.2037 23:59";}}
[alt] => Alternativer Text
[articleId] => 122
[author] => 4
[begin] => 1462525860
[caption] =>
[class] =>  bygone
[classHeader] =>  even first last
[classList] =>  bygone even first last cal_3
[classUpcoming] =>  bygone even first last cal_3
[cssClass] =>
[date] => 06.05.2016
[datetime] => 2016-05-06T11:11:00+02:00
[day] => Friday
[end] => 1462566120
[endDate] =>
[endTime] => 1462566120
[exceptionList] =>
[externalUrl] => http://andreasburg.de/
[firstDate] => 06.05.2016
[firstDay] => Friday
[floatClass] =>  float_right
[floating] => right
[fullsize] =>
[hasDetails] => 1
[hasTeaser] => 1
[header] => 1
[height] => 750
[hideOnWeekend] =>
[href] => en/event-detail/contao-north-day-10.html
[id] => 10
[ignoreEndTime] =>
[imagemargin] => a:5:{s:6:"bottom";s:0:"";s:4:"left";s:0:"";s:5:"right";s:0:"";s:3:"top";s:0:"";s:4:"unit";s:0:"";}
[imageUrl] =>
[imgSize] =>  width="200" height="125"
[jumpTo] => 1
[languageMain] => 0
[link] => Contao North-Day
[linkTitle] => Contao North-Day
[location] => Veranstaltungsort
[location_contact] =>
[location_link] =>
[location_mail] =>
[location_name] =>
[location_ort] =>
[location_plz] =>
[location_str] =>
[locationLabel] => Location
[margin] =>
[month] => May
[more] => Read more …
[newMonth] => 1
[noComments] =>
[parent] => 3
[pid] => 3
[published] => 1
[readMore] => Read the article: Contao North-Day
[recurrences] => 0
[recurring] => This event is repeated every 1. year
[recurringExt] =>
[regconfirm] =>
[regenddate] =>
[regform] => 0
[regperson] =>
[regstartdate] =>
[repeatDates] => a:22:{i:1462485600;s:16:"06.05.2016 00:00";i:1494021600;s:16:"06.05.2017 00:00";i:1525557600;s:16:"06.05.2018 00:00";i:1557093600;s:16:"06.05.2019 00:00";i:1588716000;s:16:"06.05.2020 00:00";i:1620252000;s:16:"06.05.2021 00:00";i:1651788000;s:16:"06.05.2022 00:00";i:1683324000;s:16:"06.05.2023 00:00";i:1714946400;s:16:"06.05.2024 00:00";i:1746482400;s:16:"06.05.2025 00:00";i:1778018400;s:16:"06.05.2026 00:00";i:1809554400;s:16:"06.05.2027 00:00";i:1841176800;s:16:"06.05.2028 00:00";i:1872712800;s:16:"06.05.2029 00:00";i:1904248800;s:16:"06.05.2030 00:00";i:1935784800;s:16:"06.05.2031 00:00";i:1967407200;s:16:"06.05.2032 00:00";i:1998943200;s:16:"06.05.2033 00:00";i:2030479200;s:16:"06.05.2034 00:00";i:2062015200;s:16:"06.05.2035 00:00";i:2093637600;s:16:"06.05.2036 00:00";i:2125173600;s:16:"06.05.2037 00:00";}
[repeatEach] => a:2:{s:4:"unit";s:5:"years";s:5:"value";s:1:"1";}
[repeatEachExt] =>
[repeatEnd] => 2145913200
[repeatExceptions] =>
[repeatExceptionsInt] =>
[repeatExceptionsPer] =>
[repeatFixedDates] => a:1:{i:0;a:4:{s:10:"new_repeat";s:0:"";s:9:"new_start";s:0:"";s:7:"new_end";s:0:"";s:6:"reason";s:0:"";}}
[repeatWeekday] =>
[showOnFreeDay] =>
[singleSRC] => files/samples/pic_011.jpg
[size] => a:3:{i:0;s:3:"200";i:1;s:0:"";i:2;s:12:"proportional";}
[source] => default
[src] => assets/images/7/pic_011-73ce1a07.jpg
[start] =>
[startDate] => 1462485600
[startTime] => 1462525860
[stop] =>
[target] =>
[teaser] => <p>The Contao North-Day is an event dedicated to Contao users, developers and supportes situated in the north of Germany. The event started in 2013 and takes place in Hamburg. In a series of presentations participants get the chance to learn from first hand experience from expterts of varying fields and to expand their horizons in the website development context. [nbsp]</p>
[time] => 11:11 – 22:22
[title] => Contao North-Day
[tstamp] => 1473609586
[until] =>
[url] => http://andreasburg.de
[useExceptions] =>
[useRegistration] =>
[weekday] => 5
[width] => 1200

[11-Sep-2016 18:39:04] 

file: /home/www/_c35/templates/event_full.html5 (line 13)

[addBefore] => 1
[addEnclosure] =>
[addImage] => 1
[addTime] => 1
[alias] => contao-north-day-10
[allRecurrences] => a:22:{i:1462485600;a:4:{s:9:"int_start";s:10:"1462485600";s:7:"int_end";i:1462571999;s:9:"str_start";s:16:"06.05.2016 00:00";s:7:"str_end";s:16:"06.05.2016 23:59";}i:1494021600;a:4:{s:9:"int_start";i:1494021600;s:7:"int_end";i:1494107999;s:9:"str_start";s:16:"06.05.2017 00:00";s:7:"str_end";s:16:"06.05.2017 23:59";}i:1525557600;a:4:{s:9:"int_start";i:1525557600;s:7:"int_end";i:1525643999;s:9:"str_start";s:16:"06.05.2018 00:00";s:7:"str_end";s:16:"06.05.2018 23:59";}i:1557093600;a:4:{s:9:"int_start";i:1557093600;s:7:"int_end";i:1557179999;s:9:"str_start";s:16:"06.05.2019 00:00";s:7:"str_end";s:16:"06.05.2019 23:59";}i:1588716000;a:4:{s:9:"int_start";i:1588716000;s:7:"int_end";i:1588802399;s:9:"str_start";s:16:"06.05.2020 00:00";s:7:"str_end";s:16:"06.05.2020 23:59";}i:1620252000;a:4:{s:9:"int_start";i:1620252000;s:7:"int_end";i:1620338399;s:9:"str_start";s:16:"06.05.2021 00:00";s:7:"str_end";s:16:"06.05.2021 23:59";}i:1651788000;a:4:{s:9:"int_start";i:1651788000;s:7:"int_end";i:1651874399;s:9:"str_start";s:16:"06.05.2022 00:00";s:7:"str_end";s:16:"06.05.2022 23:59";}i:1683324000;a:4:{s:9:"int_start";i:1683324000;s:7:"int_end";i:1683410399;s:9:"str_start";s:16:"06.05.2023 00:00";s:7:"str_end";s:16:"06.05.2023 23:59";}i:1714946400;a:4:{s:9:"int_start";i:1714946400;s:7:"int_end";i:1715032799;s:9:"str_start";s:16:"06.05.2024 00:00";s:7:"str_end";s:16:"06.05.2024 23:59";}i:1746482400;a:4:{s:9:"int_start";i:1746482400;s:7:"int_end";i:1746568799;s:9:"str_start";s:16:"06.05.2025 00:00";s:7:"str_end";s:16:"06.05.2025 23:59";}i:1778018400;a:4:{s:9:"int_start";i:1778018400;s:7:"int_end";i:1778104799;s:9:"str_start";s:16:"06.05.2026 00:00";s:7:"str_end";s:16:"06.05.2026 23:59";}i:1809554400;a:4:{s:9:"int_start";i:1809554400;s:7:"int_end";i:1809640799;s:9:"str_start";s:16:"06.05.2027 00:00";s:7:"str_end";s:16:"06.05.2027 23:59";}i:1841176800;a:4:{s:9:"int_start";i:1841176800;s:7:"int_end";i:1841263199;s:9:"str_start";s:16:"06.05.2028 00:00";s:7:"str_end";s:16:"06.05.2028 23:59";}i:1872712800;a:4:{s:9:"int_start";i:1872712800;s:7:"int_end";i:1872799199;s:9:"str_start";s:16:"06.05.2029 00:00";s:7:"str_end";s:16:"06.05.2029 23:59";}i:1904248800;a:4:{s:9:"int_start";i:1904248800;s:7:"int_end";i:1904335199;s:9:"str_start";s:16:"06.05.2030 00:00";s:7:"str_end";s:16:"06.05.2030 23:59";}i:1935784800;a:4:{s:9:"int_start";i:1935784800;s:7:"int_end";i:1935871199;s:9:"str_start";s:16:"06.05.2031 00:00";s:7:"str_end";s:16:"06.05.2031 23:59";}i:1967407200;a:4:{s:9:"int_start";i:1967407200;s:7:"int_end";i:1967493599;s:9:"str_start";s:16:"06.05.2032 00:00";s:7:"str_end";s:16:"06.05.2032 23:59";}i:1998943200;a:4:{s:9:"int_start";i:1998943200;s:7:"int_end";i:1999029599;s:9:"str_start";s:16:"06.05.2033 00:00";s:7:"str_end";s:16:"06.05.2033 23:59";}i:2030479200;a:4:{s:9:"int_start";i:2030479200;s:7:"int_end";i:2030565599;s:9:"str_start";s:16:"06.05.2034 00:00";s:7:"str_end";s:16:"06.05.2034 23:59";}i:2062015200;a:4:{s:9:"int_start";i:2062015200;s:7:"int_end";i:2062101599;s:9:"str_start";s:16:"06.05.2035 00:00";s:7:"str_end";s:16:"06.05.2035 23:59";}i:2093637600;a:4:{s:9:"int_start";i:2093637600;s:7:"int_end";i:2093723999;s:9:"str_start";s:16:"06.05.2036 00:00";s:7:"str_end";s:16:"06.05.2036 23:59";}i:2125173600;a:4:{s:9:"int_start";i:2125173600;s:7:"int_end";i:2125259999;s:9:"str_start";s:16:"06.05.2037 00:00";s:7:"str_end";s:16:"06.05.2037 23:59";}}
[alt] => Alternativer Text
[articleId] => 122
[author] => 4
[begin] => 1494061860
[caption] =>
[class] =>
[cssClass] =>
[date] => 06.05.2017
[datetime] => 2017-05-06T11:11:00+02:00
[end] => 1494102120
[endDate] =>
[endTime] => 1462566120
[exceptionList] =>
[externalUrl] => http://andreasburg.de/
[floatClass] =>  float_right
[floating] => right
[fullsize] =>
[hasDetails] => 1
[hasTeaser] => 1
[height] => 750
[hideOnWeekend] =>
[id] => 10
[ignoreEndTime] =>
[imagemargin] => a:5:{s:6:"bottom";s:0:"";s:4:"left";s:0:"";s:5:"right";s:0:"";s:3:"top";s:0:"";s:4:"unit";s:0:"";}
[imageUrl] =>
[imgSize] =>  width="300" height="188"
[jumpTo] => 1
[languageMain] => 0
[linkTitle] => Contao North-Day
[location] => Veranstaltungsort
[location_contact] =>
[location_link] =>
[location_mail] =>
[location_name] =>
[location_ort] =>
[location_plz] =>
[location_str] =>
[locationLabel] => Location
[margin] =>
[noComments] =>
[pid] => 3
[published] => 1
[recurrences] => 0
[recurring] => This event is repeated every 1. year
[recurringExt] =>
[regconfirm] =>
[regenddate] =>
[regform] => 0
[regperson] =>
[regstartdate] =>
[repeatDates] => a:22:{i:1462485600;s:16:"06.05.2016 00:00";i:1494021600;s:16:"06.05.2017 00:00";i:1525557600;s:16:"06.05.2018 00:00";i:1557093600;s:16:"06.05.2019 00:00";i:1588716000;s:16:"06.05.2020 00:00";i:1620252000;s:16:"06.05.2021 00:00";i:1651788000;s:16:"06.05.2022 00:00";i:1683324000;s:16:"06.05.2023 00:00";i:1714946400;s:16:"06.05.2024 00:00";i:1746482400;s:16:"06.05.2025 00:00";i:1778018400;s:16:"06.05.2026 00:00";i:1809554400;s:16:"06.05.2027 00:00";i:1841176800;s:16:"06.05.2028 00:00";i:1872712800;s:16:"06.05.2029 00:00";i:1904248800;s:16:"06.05.2030 00:00";i:1935784800;s:16:"06.05.2031 00:00";i:1967407200;s:16:"06.05.2032 00:00";i:1998943200;s:16:"06.05.2033 00:00";i:2030479200;s:16:"06.05.2034 00:00";i:2062015200;s:16:"06.05.2035 00:00";i:2093637600;s:16:"06.05.2036 00:00";i:2125173600;s:16:"06.05.2037 00:00";}
[repeatEach] => a:2:{s:4:"unit";s:5:"years";s:5:"value";s:1:"1";}
[repeatEachExt] =>
[repeatEnd] => 2145913200
[repeatExceptions] =>
[repeatExceptionsInt] =>
[repeatExceptionsPer] =>
[repeatFixedDates] => a:1:{i:0;a:4:{s:10:"new_repeat";s:0:"";s:9:"new_start";s:0:"";s:7:"new_end";s:0:"";s:6:"reason";s:0:"";}}
[repeatWeekday] =>
[showOnFreeDay] =>
[singleSRC] => files/samples/pic_011.jpg
[size] => a:3:{i:0;s:3:"200";i:1;s:0:"";i:2;s:12:"proportional";}
[source] => default
[src] => assets/images/d/pic_011-aae3cc8d.jpg
[start] =>
[startDate] => 1462485600
[startTime] => 1462525860
[stop] =>
[target] =>
[teaser] => <p>The Contao North-Day is an event dedicated to Contao users, developers and supportes situated in the north of Germany. The event started in 2013 and takes place in Hamburg. In a series of presentations participants get the chance to learn from first hand experience from expterts of varying fields and to expand their horizons in the website development context. [nbsp]</p>
[time] => 11:11 – 22:22
[title] => Contao North-Day
[tstamp] => 1473609586
[until] =>
[url] => http://andreasburg.de
[useExceptions] =>
[useRegistration] =>
[weekday] => 5
[width] => 1200

Aybee avatar Sep 12 '16 18:09 Aybee