contao-manager icon indicating copy to clipboard operation
contao-manager copied to clipboard

route_prefix in config.yml not respected

Open falkgeist opened this issue 2 years ago • 2 comments

E.g. when updating packages, you can directly update the database. The href for that button uses the URL "/contao/install", but with the changes from contao/contao#1999 it should respect the changes in the config.yml for the route_prefix, if present.

falkgeist avatar Jun 14 '22 09:06 falkgeist

The Contao Manager unfortunately cannot know about that configuration. Luckly, we'll get rid of the install tool soon, so this link shouldn't be necessary anymore 🙃

aschempp avatar Jun 15 '22 12:06 aschempp

I additionally just noticed that this issue also applies to all other backend links in the manager. Namely the ones in the "Tools" section... If the manager can't know about this configuration, maybe get rid of the links (although I find them relatively useful) or introduce a variable in the manager itself, where you can copy the route from the Contao configuration. Anyways, was just a small issue, nothing important.

falkgeist avatar Jun 15 '22 13:06 falkgeist

We could do that if debug:config contao can be read as JSON which is actually planned for the upcoming Symfony 6.3. However, there is still some formatting issue - see https://github.com/symfony/symfony/pull/48457.

Toflar avatar May 04 '23 13:05 Toflar

I've created a PR to fix this in Symfony which has now been merged into 6.3: https://github.com/symfony/symfony/pull/50637

Toflar avatar Jun 24 '23 10:06 Toflar

This will be supported in the next Contao Manager with the latest Contao versions.

aschempp avatar Oct 02 '23 07:10 aschempp