Time Namespace

[CheatCodeSam]

Description

Adding the time namespace.

Type of Change

• [ ] Bug fix (non-breaking change that fixes an issue)
• [X] New feature (non-breaking change that adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation update
• [ ] Refactoring (no functional changes)
• [ ] Performance improvement
• [ ] Test updates
• [ ] CI/CD related changes
• [ ] Other (please describe):

Testing

• [ ] Added new unit tests
• [x] Added new integration tests
• [x] Ran existing test suite
• [x] Tested manually (please provide steps)

Related Issues

Fixes #3259

Additional Context

[CheatCodeSam]

Hello @saku3, This should be done in terms of implementation. I'm just curious what I should add the integration tests. I have one test where it just checks if a container with a time namespace can be created at all.

[CheatCodeSam]

Works on my machine :(, using the same binary as the one built by the ci above. Weird fluke? Logs aren't helpful.

[saku3]

Thank you for the implementation. For integration tests, you can refer to the following. https://github.com/opencontainers/runc/blob/main/tests/integration/timens.bats

The oci-validation-go tests occasionally fail, so I think it’s fine not to worry about them for now.”

[CheatCodeSam]

Integration tests are done, it should be worth checking this out now.

[saku3]

@CheatCodeSam Sorry for the late review. I’d appreciate it if you could resolve the conflicts.

[CheatCodeSam]

Good to go

[utam0k]

@saku3 Could I ask you to review this PR as the first reviewer?

[saku3]

Sure, I can review it.

[CheatCodeSam]

Works on my machine, :( This is ready for re-review