virtcontainers

virtcontainers copied to clipboard

Missing isolation descriptions

3

The container and pod configuration structures do not yet contain isolation descriptions. The isolation structures are not defined.

sameo

startPod() leaks a socket and a go routine

5

Shut the QMP socket down and clean the qmp listen routine when pod.startPod() is done

sameo

`startCCShimStartWithoutConsoleSuccessful()` messes with standard streams and if the following two tests are not disabled, running the unit tests locally will hang forever: - `TestCCShimStartSuccessful` - `TestCCShimStartDetachSuccessful`

jodh-intel

Switch tests to use a testing framework that provides fixtures (test setup / tear down functions).

6

The tests are currently using the `testing` package, but http://labix.org/gocheck is much more powerful (and compatible with `testing`). Crucially the latter offers test fixtures like `SetUpTest()` and `TearDownTest()` to simplify...

jodh-intel

The `virtc` binary does not provide a `container kill` feature meaning `KillContainer()` cannot be tested at the functional level in isolation from the runtime (which exercises it via `cc-runtime kill`)....

jodh-intel

We need to grow a set of `virtc` [BATS](https://github.com/sstephenson/bats) tests run by the CI which exercise all API calls. Related: #495.

jodh-intel

Now that we've increased the runtime unit-test coverage, we should probably re-assess the virtcontainers level of coverage which is now lower than the runtime by some margin.

jodh-intel

Debate what the default number of VCPUs should be

10

Currently we set the default number of VCPUs to be 1: https://github.com/containers/virtcontainers/blob/master/hypervisor.go#L36 This is one obvious and safe default, but from some testing (under https://github.com/clearcontainers/runtime), it seems that running up...

grahamwhaley

``` $ sudo virtc container create --pod-id=34d33aa0-b9cb-4a4e-ba61-d063fcaaa144 --rootfs=/home/james/tmp/oci --cmd sh -id foo --console /dev/pts/4 INFO[0000] Info structure: {ID:34d33aa0-b9cb-4a4e-ba61-d063fcaaa144 Hooks:{PreStartHooks:[] PostStartHooks:[] PostStopHooks:[]} VMConfig:{VCPUs:0 Memory:0} HypervisorType:qemu HypervisorConfig:{KernelPath:/usr/share/clear-containers/vmlinux.container ImagePath:/usr/share/clear-containers/clear-containers.img HypervisorPath: KernelParams:[] HypervisorParams:[] HypervisorMachineType:pc-lite...

jodh-intel

_From @jcvenegas on May 11, 2017 14:2_ _From @jodh-intel on February 17, 2017 16:59_ We need to consider making the hypervisor shutdown automatically if it detects that either the proxy...

sameo