toolbox create: always offer to pull

This PR addresses 2 common user issues with toolbox create:

users need to manually download newer images themselves
~~the hardcoded "500MB download" is misleading~~

I have tested this locally and it seems to work okay for me.

Sep 13 '21 17:09 juhp

Build succeeded.

unit-test : SUCCESS in 2m 51s
system-test-fedora-33 : SUCCESS in 10m 36s
system-test-fedora-34 : SUCCESS in 10m 34s
system-test-fedora-rawhide : SUCCESS in 19m 07s

Sep 13 '21 17:09 softwarefactory-project-zuul[bot]

Any feedback on this? It is quite small :)

Oct 15 '21 04:10 juhp

Build failed.

unit-test : SUCCESS in 5m 03s
system-test-fedora-33 : SUCCESS in 11m 26s
system-test-fedora-34 : SUCCESS in 10m 43s
system-test-fedora-rawhide : TIMED_OUT in 20m 51s

Nov 16 '21 07:11 softwarefactory-project-zuul[bot]

So how about this Download <<image>> (image size ~400MB) then. Any better?

Nov 16 '21 07:11 juhp

Build failed.

unit-test : SUCCESS in 4m 21s
system-test-fedora-33 : SUCCESS in 10m 41s
system-test-fedora-34 : SUCCESS in 11m 12s
system-test-fedora-rawhide : TIMED_OUT in 20m 46s

Nov 16 '21 08:11 softwarefactory-project-zuul[bot]

An alternative for the pull part could be to make it an option instead:

ie toolbox create --pull ...

That would make it opt-in which should alleviate the storage space concerns with pulling newer images. (Personally I would prefer to offer to pull by default since it is too easy to forget to pull, but at least having the command option makes it more visible and easy to update. It might be nice to add a purge command eventually specifically for removing obsolete toolbox images.)

Though in it's current form the user can already say "no" to downloading a newer image: they are prompted each time.

Nov 16 '21 09:11 juhp

So how about this Download <<image>> (image size ~400MB) then. Any better?

Well, the best option would be to comment on https://github.com/containers/skopeo/issues/641 and push for it to get prioritized. It's not entirely trivial to get the exact size of the image.

Nov 16 '21 22:11 debarshiray

Okay, sure, thank you for the detailed replies and clarity: let's drop the size part of this PR completely.

(Actually I had not realized that skopeo was only exposing local image sizes.)

Nov 17 '21 10:11 juhp

Build failed.

unit-test : SUCCESS in 5m 43s
system-test-fedora-33 : SUCCESS in 12m 15s
system-test-fedora-34 : SUCCESS in 10m 25s
system-test-fedora-rawhide : TIMED_OUT in 21m 05s

Nov 17 '21 10:11 softwarefactory-project-zuul[bot]

Any hope of reviving this PR? It would vastly simplify the documentation on how to upgrade the Developer Toolbox I maintain, for instance.

Mar 19 '24 12:03 sgallagher

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/f52aae5400a542dfb3972981e359fd43

:heavy_check_mark: unit-test SUCCESS in 5m 33s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 33s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 25s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 38m 19s :heavy_check_mark: system-test-fedora-40 SUCCESS in 36m 37s :heavy_check_mark: system-test-fedora-39 SUCCESS in 36m 01s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 45s

Jul 07 '24 06:07 softwarefactory-project-zuul[bot]

I made my main branch current, which caused this PR to close - not that it was going anywhere...

Anyway you can still find my original proposal in https://github.com/containers/toolbox/commit/8bfbbf4c5e58e2f002f517df8deed8bf1ba8effd in (https://github.com/juhp/toolbox/tree/always-pull) (I think that was it basically)

Jul 10 '24 16:07 juhp