toolbox icon indicating copy to clipboard operation
toolbox copied to clipboard

test/system: Fix ulimit tests on Ubuntu host

Open petraglyph opened this issue 1 year ago • 1 comments

ulimit is a shell builtin, so the shell it is run from changes the version that is used. Ubuntu (and Debian) use dash as their system shell, instead of bash. The means that toolbox run also used dash with Ubuntu containers, caused an unexpected version of ulimit to be used in tests. Tests were updated to force the use of bash and its version of ulimit.

petraglyph avatar Nov 29 '24 09:11 petraglyph

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/af8efdf03f614299bec5c9a5fddc5ca1

:heavy_check_mark: unit-test SUCCESS in 7m 33s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 11s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 37s :heavy_check_mark: system-test-fedora-rawhide-commands-options SUCCESS in 1h 23m 41s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 30m 35s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 39m 47s :x: system-test-fedora-41-commands-options POST_FAILURE in 1h 12m 47s :heavy_check_mark: system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 29m 47s :heavy_check_mark: system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 33m 01s :heavy_check_mark: system-test-fedora-40-commands-options SUCCESS in 1h 21m 12s :heavy_check_mark: system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 30m 25s :heavy_check_mark: system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 36m 02s :heavy_check_mark: system-test-fedora-39-commands-options SUCCESS in 1h 23m 21s :heavy_check_mark: system-test-fedora-39-runtime-environment-arch-fedora SUCCESS in 1h 30m 32s :heavy_check_mark: system-test-fedora-39-runtime-environment-ubuntu SUCCESS in 39m 35s

We should add test/system/210-ulimit.bats to .github/workflows/ubuntu-tests.yaml to enable them in the CI.

I took the liberty to do this, and rebased on top of main. The commit message still needs fixing.

debarshiray avatar Jul 16 '25 00:07 debarshiray

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/8dd053407f624c1bba56d22e070deb9c

:heavy_check_mark: unit-test SUCCESS in 5m 39s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 39s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 04s :heavy_check_mark: system-test-fedora-rawhide-commands-options SUCCESS in 1h 31m 23s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 17m 56s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 21m 15s :heavy_check_mark: system-test-fedora-42-commands-options SUCCESS in 1h 27m 05s :heavy_check_mark: system-test-fedora-42-runtime-environment-arch-fedora SUCCESS in 1h 11m 31s :heavy_check_mark: system-test-fedora-42-runtime-environment-ubuntu SUCCESS in 17m 20s :heavy_check_mark: system-test-fedora-41-commands-options SUCCESS in 1h 27m 14s :heavy_check_mark: system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 18m 44s :heavy_check_mark: system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 20m 48s

The commit message still needs fixing.

I took the liberty to update the commit message.

I didn't want to delay this any further because of relatively minor details.

debarshiray avatar Jul 16 '25 13:07 debarshiray

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/3df20a4d06df4d62a2dc69bc4878445e

:heavy_check_mark: unit-test SUCCESS in 5m 52s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 39s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 41s :heavy_check_mark: system-test-fedora-rawhide-commands-options SUCCESS in 1h 24m 11s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 12m 46s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 16m 33s :heavy_check_mark: system-test-fedora-42-commands-options SUCCESS in 1h 22m 58s :heavy_check_mark: system-test-fedora-42-runtime-environment-arch-fedora SUCCESS in 1h 12m 33s :heavy_check_mark: system-test-fedora-42-runtime-environment-ubuntu SUCCESS in 18m 17s :heavy_check_mark: system-test-fedora-41-commands-options SUCCESS in 1h 23m 55s :heavy_check_mark: system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 12m 36s :heavy_check_mark: system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 16m 41s