toolbox icon indicating copy to clipboard operation
toolbox copied to clipboard

fixes #1564 usr home

Open sumantro93 opened this issue 1 year ago • 5 comments

Add fixes for 1564

sumantro93 avatar Oct 31 '24 14:10 sumantro93

Hi @debarshiray, I started using toolbox few days back and ran into the same issue this PR is trying to fix. This PR doesn't seem active. Is it okay if I raise a new PR addressing the comments you have given along with @sumantro93 initial commits?

wazir-ahmed avatar Jun 17 '25 17:06 wazir-ahmed

Could you please try to squash the commits into logical units that successfully build and pass the tests, instead of a series of fix-up commits?

Okay, I'm just reading this comment. I will squash all the changes in my new PR.

wazir-ahmed avatar Jun 17 '25 18:06 wazir-ahmed

I started using toolbox few days back and ran into the same issue this PR is trying to fix. This PR doesn't seem active. Is it okay if I raise a new PR addressing the comments you have given along with @sumantro93 initial commits?

Hey! I apologize that I didn't respond earlier.

I started working on a branch to isolate the host's HOME from the system tests, and that can only be done by addressing this problem. So, I had to adopt this PR myself.

Are you looking for newcomer-friendly issues to work on? If so, please reach out to me via email and I can point you to some.

Once again, sorry for the late response; and thanks for stopping by and playing with Toolbx.

debarshiray avatar Jun 26 '25 20:06 debarshiray

Closing in favour of https://github.com/containers/toolbox/pull/1667

debarshiray avatar Jun 26 '25 20:06 debarshiray