toolbox
toolbox copied to clipboard
containers
Improve the error message when running nested inside a non-Toolbx container
Fixes issue https://github.com/containers/toolbox/issues/1183
Signed-off-by: Nieves Montero [email protected]
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/75438452a5fb458ba31b16a11253b4f0
:heavy_check_mark: unit-test SUCCESS in 9m 32s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 57s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 26s :x: system-test-fedora-rawhide FAILURE in 20m 30s :x: system-test-fedora-38 FAILURE in 20m 29s :x: system-test-fedora-37 FAILURE in 19m 37s :x: system-test-fedora-36 FAILURE in 19m 42s
![softwarefactory-project-zuul[bot] avatar](https://avatars.githubusercontent.com/in/6924?v=4 "Published by a pub.dev verified publisher"){kind=small}
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/e56e05b64ef942c8aeddfed91fe448d6
:heavy_check_mark: unit-test SUCCESS in 9m 44s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 31s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 20s :x: system-test-fedora-rawhide FAILURE in 20m 19s :x: system-test-fedora-38 FAILURE in 20m 18s :x: system-test-fedora-37 FAILURE in 20m 27s :x: system-test-fedora-36 FAILURE in 20m 11s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/6c859657908e4c7488f85240159e18de
:heavy_check_mark: unit-test SUCCESS in 9m 21s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 20s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 28s :x: system-test-fedora-rawhide FAILURE in 20m 01s :x: system-test-fedora-38 FAILURE in 20m 15s :x: system-test-fedora-37 FAILURE in 19m 15s :x: system-test-fedora-36 FAILURE in 19m 10s
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/02243c22962341c28685ba288cf277e4
:heavy_check_mark: unit-test SUCCESS in 9m 16s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 11s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 19s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 21m 05s :heavy_check_mark: system-test-fedora-38 SUCCESS in 20m 03s :heavy_check_mark: system-test-fedora-37 SUCCESS in 19m 12s :heavy_check_mark: system-test-fedora-36 SUCCESS in 19m 17s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/2f82e17a8e084fe89a9ffe964cf125bc
:x: unit-test FAILURE in 9m 18s :x: unit-test-migration-path-for-coreos-toolbox FAILURE in 2m 44s :x: unit-test-restricted FAILURE in 8m 19s :x: system-test-fedora-rawhide FAILURE in 9m 17s :x: system-test-fedora-38 FAILURE in 9m 13s :x: system-test-fedora-37 FAILURE in 9m 11s :x: system-test-fedora-36 FAILURE in 9m 03s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/72c6ce0296ea4309a5a2a292a147d3ca
:heavy_check_mark: unit-test SUCCESS in 9m 46s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 43s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 35s :x: system-test-fedora-rawhide FAILURE in 20m 14s :x: system-test-fedora-38 FAILURE in 20m 27s :x: system-test-fedora-37 FAILURE in 19m 56s :x: system-test-fedora-36 FAILURE in 20m 02s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/e0273448a0a548a3996d9d3785962194
:heavy_check_mark: unit-test SUCCESS in 9m 29s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 30s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 33s :x: system-test-fedora-rawhide FAILURE in 20m 03s :x: system-test-fedora-38 FAILURE in 20m 29s :x: system-test-fedora-37 FAILURE in 19m 46s :x: system-test-fedora-36 FAILURE in 19m 42s
Is this a continuation of #1191 ? It would have been better to continue using the old pull request to keep all the discussion in one place.
Anyway, the tests are failing, and the branch has conflicts. Did you check the test logs to understand why they are failing? The tests really need to pass.
I paused this PR and moved to https://github.com/containers/toolbox/pull/1301 to first fix the tests. I expect this PR to be fixed once https://github.com/containers/toolbox/pull/1301 is fixed.
Is this a continuation of #1191 ? It would have been better to continue using the old pull request to keep all the discussion in one place. Anyway, the tests are failing, and the branch has conflicts. Did you check the test logs to understand why they are failing? The tests really need to pass.
I paused this PR and moved to #1301 to first fix the tests. I expect this PR to be fixed once #1301 is fixed.
Did the tests get fixed for this pull request? Last time they were failing and they haven't been run lately.
It also looks like this branch conflicts with main. Could you please git rebase ... it?
Merge Failed.
This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging github.com/containers/toolbox for 1295,fcb73d26abb7f0c07379a1a8d47d3de2d4400287
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/dbf19b014b674471b3cbda54dd2d1093
:x: unit-test RETRY_LIMIT in 7m 09s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 12s :x: unit-test-restricted RETRY_LIMIT in 5m 56s :x: system-test-fedora-rawhide RETRY_LIMIT in 7m 14s :x: system-test-fedora-39 RETRY_LIMIT in 7m 12s :x: system-test-fedora-38 RETRY_LIMIT in 7m 12s :x: system-test-fedora-37 RETRY_LIMIT in 6m 53s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/558854fe01d84c308b81e724cf0d859a
:x: unit-test RETRY_LIMIT in 6m 55s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 23s :x: unit-test-restricted RETRY_LIMIT in 5m 59s :x: system-test-fedora-rawhide RETRY_LIMIT in 6m 53s :x: system-test-fedora-39 RETRY_LIMIT in 6m 58s :x: system-test-fedora-38 RETRY_LIMIT in 6m 53s :x: system-test-fedora-37 RETRY_LIMIT in 6m 53s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/8590f159fe4b4da7af7be1e5808e9de3
:heavy_check_mark: unit-test SUCCESS in 9m 05s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 40s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 20s :x: system-test-fedora-rawhide FAILURE in 45m 59s :x: system-test-fedora-39 FAILURE in 45m 24s :heavy_check_mark: system-test-fedora-38 SUCCESS in 34m 02s :heavy_check_mark: system-test-fedora-37 SUCCESS in 39m 11s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/c52c6f52e84f4cd68354676f2e801acb
:heavy_check_mark: unit-test SUCCESS in 9m 13s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 37s :heavy_check_mark: unit-test-restricted SUCCESS in 9m 17s :x: system-test-fedora-rawhide FAILURE in 27m 13s :x: system-test-fedora-39 FAILURE in 28m 57s :x: system-test-fedora-38 FAILURE in 28m 00s :x: system-test-fedora-37 FAILURE in 28m 30s
Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/83dd5a44ba224679ab96f7567d18f055
:heavy_check_mark: unit-test SUCCESS in 8m 38s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 9m 17s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 02s :x: system-test-fedora-rawhide FAILURE in 28m 18s :x: system-test-fedora-39 FAILURE in 28m 18s :x: system-test-fedora-38 FAILURE in 28m 13s :x: system-test-fedora-37 FAILURE in 27m 55s
Ping. What's the status of this pull request?
I put it aside while working on the other PRs. I am stuck because of the problem mentioned here https://github.com/containers/toolbox/pull/1295#discussion_r1380165358 by @HarryMichal The changes I made to add the error make the tests fail on the CI.