zfs cmd syntax wrong - cannot work

[chymian]

this seems to be a long stand bug. the internal cmd used by podman to check a ZFS dataset/fs has a wrong syntax and must always error – was mentioned already 3 years ago.

there is no such parameter like fs in zfs fs …

Context:

rootless:

podman system reset
Error: configure storage: cannot find root filesystem dataz/home/guenter/.local/share/containers: exit status 1: 
"/usr/bin/zfs fs list -rHp -t filesystem -o name,origin,used,available,mountpoint,compression,type,volsize,quota,referenced,written,logicalused,usedbydataset dataz/home/guenter/.local/share/containers" => cannot open 'dataz/home/guenter/.local/share/containers': dataset does not exist

and removing the erroneous fs

/usr/bin/zfs  list -rHp -t filesystem -o name,origin,used,available,mountpoint,compression,type,volsize,quota,referenced,written,logicalused,usedbydataset dataz/home/guenter/.local/share/containers
dataz/home/guenter/.local/share/containers      -       1748750336      2220284936192   /home/guenter/.local/share/containers   zstd    filesystem      -       0       339968  339968  1783496704      339968
dataz/home/guenter/.local/share/containers/podman       -       204800  2220284936192   /home/guenter/.local/share/containers/podman    zstd    filesystem      -       0       204800  204800  71168   204800
dataz/home/guenter/.local/share/containers/podman-desktop       -       1747963904      2220284936192   /home/guenter/.local/share/containers/podman-desktop    zstd    filesystem      -       0       1747963904      1747963904      1783099904      1747963904
dataz/home/guenter/.local/share/containers/storage      -       241664  2220284936192   /home/guenter/.local/share/containers/storage   zstd    filesystem      -       0       241664  241664  88576   241664

works!

lsb_release --all
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux trixie/sid
Release:        n/a
Codename:       trixie

zfs version
  zfs-2.2.5-1
  zfs-kmod-2.2.5-1

---

the command being generated is wrong.

/sbin/zfs fs create -o mountpoint=legacy rpool/podman/2653d992f4ef2bfd27f94db643...

...can't work. The command should be...

/sbin/zfs create -o mountpoint=legacy rpool/podman/2653d992f4ef2bfd27f94db643815aa567240c3773...

Originally posted by @awhileback in https://github.com/containers/podman/issues/11415#issuecomment-911987982