storage icon indicating copy to clipboard operation
storage copied to clipboard

FAIL: TestSetRemapUserGroupOpts

Open siretart opened this issue 1 year ago • 6 comments

The test added in https://github.com/containers/storage/pull/1620 fails while building the debian package:

=== RUN   TestSetRemapUserGroupOpts
    options_test.go:194: 
        	Error Trace:	/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/github.com/containers/storage/types/options_test.go:194
        	Error:      	Received unexpected error:
        	            	no subuid ranges found for user "siretart" in /etc/subuid
        	Test:       	TestSetRemapUserGroupOpts
--- FAIL: TestSetRemapUserGroupOpts (0.00s)

cc: @sstosh

siretart avatar Sep 14 '23 16:09 siretart

I believe the test makes assumptions that hold in CI but not on the build machines in Debian (and probably other distributions). Any chance to make the test skip automatically if /etc/subuild is not setup appropriately? -- I'd prefer to not distro patch this issue if possible

siretart avatar Sep 14 '23 16:09 siretart

I am fine with that, but what is the test? If root or entry in /etc/subuid?

rhatdan avatar Sep 14 '23 18:09 rhatdan

Debian builds often run in https://manpages.debian.org/testing/pseudo/fakeroot.1.en.html -- so just testing for UID==0 might not be the best choice. Checking for entry in /etc/subuid seems more reliable to me

siretart avatar Sep 22 '23 13:09 siretart

SGTM

rhatdan avatar Sep 24 '23 23:09 rhatdan

apparently this test was dropped in 2d959dd4bf9050a85e3b91c11083fc005577c2ed ?

siretart avatar Aug 04 '24 18:08 siretart

So we can close this issue?

rhatdan avatar Aug 05 '24 10:08 rhatdan