storage
storage copied to clipboard
FAIL: TestSetRemapUserGroupOpts
The test added in https://github.com/containers/storage/pull/1620 fails while building the debian package:
=== RUN TestSetRemapUserGroupOpts
options_test.go:194:
Error Trace: /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/github.com/containers/storage/types/options_test.go:194
Error: Received unexpected error:
no subuid ranges found for user "siretart" in /etc/subuid
Test: TestSetRemapUserGroupOpts
--- FAIL: TestSetRemapUserGroupOpts (0.00s)
cc: @sstosh
I believe the test makes assumptions that hold in CI but not on the build machines in Debian (and probably other distributions). Any chance to make the test skip automatically if /etc/subuild
is not setup appropriately? -- I'd prefer to not distro patch this issue if possible
I am fine with that, but what is the test? If root or entry in /etc/subuid?
Debian builds often run in https://manpages.debian.org/testing/pseudo/fakeroot.1.en.html -- so just testing for UID==0 might not be the best choice. Checking for entry in /etc/subuid
seems more reliable to me
SGTM
apparently this test was dropped in 2d959dd4bf9050a85e3b91c11083fc005577c2ed ?
So we can close this issue?