Switch python3-ramalama to ramalama
Because we are a python application rather than a python library, we have this option, it's more intuitive in general and puts us in line with brew install ramalama. We want to alias python3-ramalama.
Summary by Sourcery
Alias python3-ramalama to ramalama across installation instructions and scripts
Enhancements:
- Modify install script to install the
ramalamapackage name with dnf
Documentation:
- Update README install commands to use
ramalamainstead ofpython3-ramalama
Reviewer's Guide
This PR replaces all references to the Fedora package “python3-ramalama” with the new alias “ramalama” in documentation, the install script, and provisioning plans to make the installation command more intuitive and consistent.
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Replace python3-ramalama with ramalama as the default Fedora package |
|
README.mdinstall.shplans/main.fmf |
Tips and commands
Interacting with Sourcery
-
Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
-
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with
@sourcery-ai issueto create an issue from it. -
Generate a pull request title: Write
@sourcery-aianywhere in the pull request title to generate a title at any time. You can also comment@sourcery-ai titleon the pull request to (re-)generate the title at any time. -
Generate a pull request summary: Write
@sourcery-ai summaryanywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment@sourcery-ai summaryon the pull request to (re-)generate the summary at any time. -
Generate reviewer's guide: Comment
@sourcery-ai guideon the pull request to (re-)generate the reviewer's guide at any time. -
Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore. -
Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
- Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Was chatting to @carlwgeorge and we think it makes sense to change the primary name of the package to be the application/executable name and make python3-ramalama be an alias. Looping @smooge in.
Opening this draft PR so I don't forget about it.
While I was discussing this with @ericcurtin I think I mistakenly said that renaming the package didn't require a re-review, but it actually does.
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/
I'm happy to perform that official review in bugzilla once someone submits it.
Should this PR include renaming rpm/python-ramalama.spec to rpm/ramalama.spec, along with the necessary changes to the spec file?
I was wondering if it would be ok to do
Provides: ramalama
which should(?) allow for dnf install ramalama to work.
Changing the package in Fedora from python-ramalama to ramalama would require changes in the spec file, the Fedora package system, and packit to make it work. I would actually put this Patch Set as the last one to be done in that series. I can start working on this but want to make sure it is what is wanted
ramalama would be a better primary name @smooge but I trust your judgement
@smooge we heard a few comments from people in the Fedora world who felt that libraries should be python-FOOBAR, while tools should just be FOOBAR. Since ramalama is not really used as a library, then renaming everything to ramalama makes sense.
Indeed, the package guidelines state that Python libraries MUST be named with the python3- prefix (python- for the source package), but applications SHOULD be named according to the general naming guidelines.
Either this can be merged now or this has been supplanted by a different PR?
This needs to wait until I get the other one done in Fedora. Currently these changes would break someone in Fedora or EPEL. So first #1498 , then I get it reviewed and do the releng doe-see-do dance and then #1433
@ericcurtin can this move forward now?
This has been done in the main branch.