ramalama icon indicating copy to clipboard operation
ramalama copied to clipboard

Multmodal demo

Open ericcurtin opened this issue 8 months ago • 1 comments

Not to be merged

Summary by Sourcery

Update container build process, consolidate Vulkan flags, and add multi-modal demo script

New Features:

  • Add a multi-modal demo script to run SmolVLM with Podman

Enhancements:

  • Remove automatic entrypoint, RAG injection, and image cleanup from container builds for non-core targets
  • Replace GGML_KOMPUTE flags with a unified GGML_VULKAN compile flag

ericcurtin avatar May 15 '25 16:05 ericcurtin

Reviewer's Guide

This PR streamlines the container build process by removing redundant entrypoint and RAG handling, updates GPU build flags for Vulkan support, and adds a new multi-modal demo script showcasing podman execution.

File-Level Changes

Change Details Files
Simplified container build workflow
  • Removed post-build case block that added entrypoints
  • Dropped add_rag invocation in default builds
  • Eliminated rm_container_image cleanup step
  • Trimmed extra blank line before heredoc
container_build.sh
Updated GPU compilation flags
  • Replaced Kompute flags with a single GGML_VULKAN flag
  • Removed KOMPUTE_OPT_DISABLE_VULKAN_VERSION_CHECK
container-images/scripts/build_llama_and_whisper.sh
Added multi-modal demo script
  • Introduced multi-modal-demo.sh with strict error handling
  • Defined model and mmproj file paths and image ID
  • Built a comprehensive podman run command with labels, mounts, and security options
multi-modal-demo.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar May 15 '25 16:05 sourcery-ai[bot]