ramalama icon indicating copy to clipboard operation
ramalama copied to clipboard

python package fixes

Open ericcurtin opened this issue 8 months ago • 1 comments

Going to switch libexec files to just bin ones.

There are breakages because the python installers are not updating the shebangs in the libexec files, moving to bin solves this.

Summary by Sourcery

Switch core command scripts from libexec to entry points in pyproject.toml to ensure proper shebang updates by Python installers

Bug Fixes:

  • Fix shebang breakages by moving core scripts from libexec to bin entry points

Enhancements:

  • Add project.scripts entry points for client_core_main, run_core_main, and serve_core_main
  • Remove libexec directory from package include in pyproject.toml
  • Rename and relocate core scripts from libexec to module files under the package

ericcurtin avatar May 15 '25 10:05 ericcurtin

Reviewer's Guide

This PR migrates the CLI entrypoints out of libexec into standard bin scripts by updating project.scripts in pyproject.toml, removing the outdated libexec include block, and renaming the executable files to proper Python modules under the package to ensure shebang updates work correctly.

File-Level Changes

Change Details Files
Migrate script configuration from libexec to bin entry points
  • Removed the libexec include block.
  • Added three new [project.scripts] entries for client_core, run_core, and serve_core.
  • Ensured include-package-data remains enabled for scripts.
pyproject.toml
Rename and relocate CLI executables
  • Deleted legacy libexec/ramalama/* scripts.
  • Added client-core.py, run-core.py, and serve-core.py under the ramalama package.
  • Updated file names to .py modules matching new script names.
libexec/ramalama/ramalama-client-core
libexec/ramalama/ramalama-run-core
libexec/ramalama/ramalama-serve-core
ramalama/client-core.py
ramalama/run-core.py
ramalama/serve-core.py

Possibly linked issues

  • #123: PR moves executables from libexec to bin fixing the missing executable issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar May 15 '25 10:05 sourcery-ai[bot]

Is this still active, or should we close and open a new one?

rhatdan avatar Jun 13 '25 12:06 rhatdan

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jul 24 '25 00:07 github-actions[bot]

Since these files no longer exist, closing.

rhatdan avatar Jul 24 '25 10:07 rhatdan