qm icon indicating copy to clipboard operation
qm copied to clipboard

RFE: how about have a tool qm-is-ostree ?

Open dougsland opened this issue 1 year ago • 6 comments

I am wondering if we can convert this code into a generic tool for qm instead of exclusive for ffi and tests: https://github.com/containers/qm/blob/26ba84b3aaf83af045659aba4b3f71258b072d9b/tests/ffi/common/prepare.sh#L21

Why? I was looking into a way to test if we are into a ostree or not in a spec file and I couldn't easily do it. I am sure in the future, we might face another examples.

WDYT: @Yarboa @aesteve-rh @nsednev @RakeshMK90 @pengshanyu

If this issue get accepted by the maintainers, the engineer assigned could:

  • convert the code from https://github.com/containers/qm/blob/26ba84b3aaf83af045659aba4b3f71258b072d9b/tests/ffi/common/prepare.sh#L21 into a tool and add into the dir tools/ (make sure the previous call use now the tool)
  • make sure it included into rpm like others, see as example: https://github.com/containers/qm/blob/26ba84b3aaf83af045659aba4b3f71258b072d9b/rpm/qm.spec#L138

dougsland avatar Oct 01 '24 04:10 dougsland